Open uturuncoglu opened 1 year ago
Thanks @uturuncoglu . For schism I also tag @josephzhang8 .
Maybe I could go with ike_shinnecock.sch
. I think this is SCHISM forced by data atmosphere that requires only u and v wind components. I need to find data for 2008-08-23
and maybe could use CDEPS ATMMESH data mode but I need CFS data for it. @pvelissariou1 Can you also send me CFS data for those dates. It seems forecast length is 120 hours for this case.
ike_shinnecock.sch seems standalone test. So maybe it is good to start with it without worrying data atmosphere etc. Let me start with it and maybe I could define it as RT under UFS.
@platipodium @saeed-moghimi-noaa @pvelissariou1 @josephzhang8 ike_shinnecock.sch
seems working now. Is there any simple script or tool that I could use to create 2d maps etc. to check the results.
Thanks @uturuncoglu ... quite a beast to download :=).
On my M1 the command should be "./compile.sh macosx.gnu-DAPP=COASTALS -DNO_PARMETIS=ON -DOLDIO=ON" coastal YES NO
. I got as far as missing PIO...
Thanks @uturuncoglu ... quite a beast to download :=).
On my M1 the command should be
"./compile.sh macosx.gnu-DAPP=COASTALS -DNO_PARMETIS=ON -DOLDIO=ON" coastal YES NO
. I got as far as missing PIO...
New issue #3
The CMAKE_FIND package does not locate my installed PIO, I'll make a new issue
The easiest way to visualize SCHISM results may be via the matlab scripts in the source code bundle:
../schism/src/Utility/VisMatlab/SCHISM*2.m (I assume you used the new version with scribed I/O, i.e. no OLDIO turned on)
We also have schismview, a python script that needs some documentation but I can ask my staff to send you the instructions.
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 2:08 AM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@platipodiumhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fplatipodium&data=05%7C01%7Cyjzhang%40vims.edu%7C10ddfad3b75546efc9ef08db31ae545a%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158397081540482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=z%2B1H29Grk9h0CUxlPRyb6OmMw1A0S6kX2%2Fp9mHLOjJ8%3D&reserved=0 @saeed-moghimi-noaahttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsaeed-moghimi-noaa&data=05%7C01%7Cyjzhang%40vims.edu%7C10ddfad3b75546efc9ef08db31ae545a%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158397081540482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MusOAyJkoBlJtbHhsdx5Gj4Ln%2FTzq9Zv0X7bPxSyYLE%3D&reserved=0 @pvelissariou1https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpvelissariou1&data=05%7C01%7Cyjzhang%40vims.edu%7C10ddfad3b75546efc9ef08db31ae545a%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158397081540482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=U6EHrsx45VB3gTjmLSEaEEjiayTWtZyazGN0E4J1mt0%3D&reserved=0 @josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C10ddfad3b75546efc9ef08db31ae545a%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158397081540482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pReK%2B2iAgCTt7XxhcvtKHMGMHsxTr8AVOuTo1HANp6w%3D&reserved=0 ike_shinnecock.sch seems working now. Is there any simple script or tool that I could use to create 2d maps etc. to check the results.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1491349574&data=05%7C01%7Cyjzhang%40vims.edu%7C10ddfad3b75546efc9ef08db31ae545a%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158397081540482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OGtJy5QUR7UI1YGqgjZ33R5hkb5O7iYnWSBe7vA37Xk%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ7WNGUHBEY7WUGUL5LW6ZYFJANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C10ddfad3b75546efc9ef08db31ae545a%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158397081540482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=yCU16lY14%2Bt%2F9VP99H77wjrzeWMTOJMmM7J1yv2GKAM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 The exiting CoastalApp was using OLDIO (-DOLDIO=ON
) and I used that tooin my case but it is easy to test it by turning it off. Let me try.
@josephzhang8 I tried to compile without OLDIO but I am getting following error when I run the model,
3: 3: ABORT: INIT: Too few scribes (0). Please specify atleast equal to number of output variables (1)
So, maybe the configuration needs to be adjusted to run in this case. Let me know if I need to change any option in the ike_shinnecock.sch
case.
If you use OLDIO on, you should viz using SCHISM_*.m (no '2').
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 12:07 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C347599618cdb44772e6608db3201fa93%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158756333339466%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GXSqKslHrBqoIlGOVuD7vFNDMvQSYVTOvQHkwJuDDeg%3D&reserved=0 The exiting CoastalApp was using OLDIO (-DOLDIO=ON) and I used that tooin my case but it is easy to test it by turning it off. Let me try.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492202476&data=05%7C01%7Cyjzhang%40vims.edu%7C347599618cdb44772e6608db3201fa93%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158756333339466%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=22c6CYxPANd21YpmgRGWXKH1JMRlqawaBaguKfNsYxo%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ3OUTPEAMZSHINZWZ3W636KXANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C347599618cdb44772e6608db3201fa93%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158756333339466%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RNOnP8EmQYd6ejHC%2B9%2FaEwmrZYWvkXdxMpfWwVcubm4%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
When running with new I/O, you need to specify # of I/O 'scribe' processes; see
https://schism-dev.github.io/schism/master/getting-started/running-model.html
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 12:19 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C5aa562058fe34321d1b408db3203a1bc%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158763436246518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xmIIVlXDoLq54DB3wylkevwBUA79nzWZ4PTHdcABHIo%3D&reserved=0 I tried to compile without OLDIO but I am getting following error,
3: 3: ABORT: INIT: Too few scribes (0). Please specify atleast equal to number of output variables (1)
So, maybe the configuration needs to be adjusted to run in this case. Let me know if I need to change any option in the ike_shinnecock.sch case.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492221960&data=05%7C01%7Cyjzhang%40vims.edu%7C5aa562058fe34321d1b408db3203a1bc%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158763436246518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=13CuEk7ftOWTJCLee%2FKYlteZ82fwpWPhFcv8NWS0g98%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ6PXKEUB4UXCEKPAKDW637XFANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C5aa562058fe34321d1b408db3203a1bc%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158763436246518%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6YwhDQHbasT24%2Ft5JXqsKE89Ot4wNP1XSc52%2B62lrjw%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 Okay. I'll check the documentation. Thanks for your help.
Anytime, Ufuk! Thank you for helping us.
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 12:47 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C2e2e94d2ff0b4614e72b08db32078771%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158780156365611%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ct6eJw7fSWVYq5g0rhS4QL5p7eiOkbhvBWo7qQliOa4%3D&reserved=0 Okay. I'll check the documentation. Thanks for your help.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492254836&data=05%7C01%7Cyjzhang%40vims.edu%7C2e2e94d2ff0b4614e72b08db32078771%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158780156365611%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jf6xzgdUhkGTpCeqbvaz1bgLrDx5DFMnqDlAXGYqO7M%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZZXV5GWXEDQ3OGKG7LW64C7XANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C2e2e94d2ff0b4614e72b08db32078771%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158780156365611%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ivV9Ordowj72rKOzhY76jHR5fFiYi%2FZf%2FLptuEf6NoA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
Hi All,
I added new RT under tests/rt_coastal.conf (in the same branch)
./rt.sh -l rt_coastal.conf -k -n coastal_ike_shinnecock_sch
It is running in my side (still uses old I/O, once I test new one I'll fix the configuration). To run ufs_coastal related RT, you need to copy input directories and make minor change in the rt.sh to point your new input directory. Let me know if you need to access them. They are on Cheyenne.
What is next? I am plaining to continue to work and run one coupled schism configuration. It seems ike_shinnecock.atm2sch uses data atmosphere. So, running first with NUOPC connector and then with CMEPS would be good to see if we have issue with CMPES like we had in ADCIRC component. It would be also nice to sync with UFS Weather Model since lots of development done after we fork it. So, this would be a good test for syncing ufs-coastal.
@pvelissariou1 If you don't mind, could you send me CFS data for 2008-08-23? I am not sure this configuration also covers the same region like florence_hsofs.atm2adc
(maybe that test name needs to be florence_cfs.atm2adc since we are facing with CFS) but if you provide a file for me I could create ESMF mesh file for it if it is required.
@uturuncoglu @pvelissariou1 @josephzhang8 @platipodium
Very good progress indeed. I agree with staying with schism to include more of the tests. For the pull request I have no idea when would be the best time. I feel like it make sense if we start a regular weekly tag-up (perhaps just 30 min) for now only with schism developers. We are still waiting to hear back from adcirc folks. FVCOM also just finished their tests for nems-fvcom and nems-ww3-fvcom. They are also actively working with us right now. As another avenue to take if adcirc folks stayed unresponsive.
Saeed, Ufuk
Joannes just scheduled a meeting next Tuesday to discuss the CoastalApp/ADCIRC CMEPS issues. He used one of their regular meetings where all parties are participating.
Takis
Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***
On Fri, Mar 31, 2023 at 12:58 PM Saeed Moghimi @.***> wrote:
@uturuncoglu https://github.com/uturuncoglu @pvelissariou1 https://github.com/pvelissariou1 @josephzhang8 https://github.com/josephzhang8 @platipodium https://github.com/platipodium
Very good progress indeed. I agree with staying with schism to include more of the tests. For the pull request I have no idea when would be the best time. I feel like it make sense if we start a regular weekly tag-up (perhaps just 30 min) for now only with schism developers. We are still waiting to hear back from adcirc folks. FVCOM also just finished their tests for nems-fvcom and nems-ww3-fvcom. They are also actively working with us right now. As another avenue to take if adcirc folks stayed unresponsive.
— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/2#issuecomment-1492385857, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP5YXCEECSFDHJVIZNTW64LKJANCNFSM6AAAAAAWNY76MU . You are receiving this because you were mentioned.Message ID: @.***>
When I tried to clone ufs-coastal, it took >1 hr and still running, with a lot 'y'.
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 1:47 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
Hi All,
I added new RT under tests/rt_coastal.conf (in the same branch)
./rt.sh -l rt_coastal.conf -k -n coastal_ike_shinnecock_sch
It is running in my side (still uses old I/O, once I test new one I'll fix the configuration). To run ufs_coastal related RT, you need to copy input directories and make minor change in the rt.sh to point your new input directory. Let me know if you need to access them. They are on Cheyenne.
What is next? I am plaining to continue to work and run one coupled schism configuration. It seems ike_shinnecock.atm2schhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnoaa-ocs-modeling%2FCoastalApp-testsuite%2Ftree%2Fdevelop%2Fike_shinnecock.atm2sch&data=05%7C01%7Cyjzhang%40vims.edu%7C77eac092417246d5e32508db320ff3f9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158816330066916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4zjzBrJI9kRpFrSwFDVGy6xiGG%2F5tYfwUzpRAf63Z20%3D&reserved=0 uses data atmosphere. So, running first with NUOPC connector and then with CMEPS would be good to see if we have issue with CMPES like we had in ADCIRC component. It would be also nice to sync with UFS Weather Model since lots of development done after we fork it. So, this would be a good test for syncing ufs-coastal.
@pvelissariou1https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpvelissariou1&data=05%7C01%7Cyjzhang%40vims.edu%7C77eac092417246d5e32508db320ff3f9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158816330066916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OlqW7GT8RhX%2FmPL8VqOxsNIg8CFfgSYu79Cr%2BnxuJ4k%3D&reserved=0 If you don't mind, could you send me CFS data for 2008-08-23? I am not sure this configuration also covers the same region like florence_hsofs.atm2adc (maybe that test name needs to be florence_cfs.atm2adc since we are facing with CFS) but if you provide a file for me I could create ESMF mesh file for it if it is required.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492365495&data=05%7C01%7Cyjzhang%40vims.edu%7C77eac092417246d5e32508db320ff3f9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158816330066916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BnzKdcZ7HNbqixA2vf7lCWGl%2FLffLAJDmbxjXL5TyMY%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ4HLCGFLKA3736KDS3W64KB3ANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C77eac092417246d5e32508db320ff3f9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158816330066916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UmushMbdf93cMx%2BdvscBCWUkFrqy97zD1WbU6tk5qqM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 let me test in my side. If there is some issue with .gitmodules file that could create issue.
@saeed-moghimi-noaa Just to clarify. I will not have PR in UFS Weather Model side. I am just planing to bring their updates to our fork (and to branch). That is all. So we could keep up-to-date along with the development in UFS Weather Model side. I think we decided not to push anything to UFS Weather Model authoritative repository yet in our last call.
@uturuncoglu Thanks for the clarification. Understood.
@josephzhang8 Following command works for me (I named the directory as TEST).
git clone --recursive -b feature/coastal_app https://github.com/oceanmodeling/ufs-coastal.git TEST
BTW, since ADCIRC is private repository, they need to add you (maybe you are already in that group) and enter password when git asks.
Yup it works. So we'll stay in this branch for the time being.
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 4:24 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C0fdc6f1064b644406d0508db3225cd99%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158910176907713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fXV5MCmgUkRd83WM%2FUwVLLjmjAA6zsm2acUwumnIP2w%3D&reserved=0 Following command works for me (I named the directory as TEST).
git clone --recursive -b feature/coastal_app https://github.com/oceanmodeling/ufs-coastal.githttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal.git&data=05%7C01%7Cyjzhang%40vims.edu%7C0fdc6f1064b644406d0508db3225cd99%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158910176907713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XGazmufDXrTEoN3c0PPQD0QXyPOs5CgXlYd062aPnJg%3D&reserved=0 TEST
BTW, since ADCIRC is private repository, they need to add you (maybe you are already in that group) and enter password when git asks.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492570027&data=05%7C01%7Cyjzhang%40vims.edu%7C0fdc6f1064b644406d0508db3225cd99%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158910176907713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sQDqb2jDYk%2BjozKk2Xup3WpM3UMTNDy1PAokDVKQIEc%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ3ZMHQGCNEKFUZ6Z5LW644MLANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C0fdc6f1064b644406d0508db3225cd99%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158910176907713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kPSztxaiF528roVRoQpYuApQnroZhnns%2FGfMv09HFkQ%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 Yes that is the plan but we will keep it up-to-date with authoritative repository. I could also make this branch default so you don't need to specify branch in the clone but we could decide it later. I am plaining to keep develop up-to-date with authoritative repository. Anyway, we could discuss these details in the next call.
Understood; thx Ufuk!
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 4:40 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C98d9dd986c3d4ea49db708db322820d1%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158920154197811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TMOJIVPG%2B8D1M3zYtYcdh9cLq7olHWsr4vGdSatNsrQ%3D&reserved=0 Yes that is the plan but we will keep it up-to-date with authoritative repository. I could also make this branch default so you don't need to specify branch in the clone but we could decide it later. I am plaining to keep develop up-to-date with authoritative repository. Anyway, we could discuss these details in the next call.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492583694&data=05%7C01%7Cyjzhang%40vims.edu%7C98d9dd986c3d4ea49db708db322820d1%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158920154197811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2oVbTGGw1LeG5bGsGuynuvPiQJlyCgvs7AULBwV2FDQ%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ6XMAIUTNBNNW2R4JDW646KZANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C98d9dd986c3d4ea49db708db322820d1%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158920154197811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oUmOWd7Q1O7sV3jlrjy6c4LG8Wg19NGmeSvnH443Zlk%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 @platipodium I set <# scribes>
as following in my job submission script,
mpiexec_mpt -p %g: -np 4 omplace ./fv3.exe 1
but still getting same error. I think this is because of not building src/Driver
. The UFS driver does not have similar code like following,
I think we make this as an option in ESMF config file (under OCN_attributes::
group) and pass to the model with this way. I could modify the schism cap but maybe you might want to follow different approach. I think this was not used with the exiting CoastalApp since it was building with OLDIO. Anyway, let me know what you think. We could also open an another ticket for this issue.
Thx Ufuk. I think you are right; Carsten and I have not looked at the cap for new I/O. I'll work with him on this... meanwhile you can continue with OLDIO. Thx.
Joseph Zhang (804)684 7595 (office) SCHISM web: http://ccrm.vims.edu/schism/ From: Ufuk Turunçoğlu @.> Sent: Friday, March 31, 2023 5:32 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C18d0a07b4a9c4ebaffca08db322f6c1f%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158951495839859%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FOJJW09HSTanrnJQLLO4soUVffpYDLLWRygFsnAn2uk%3D&reserved=0 @platipodiumhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fplatipodium&data=05%7C01%7Cyjzhang%40vims.edu%7C18d0a07b4a9c4ebaffca08db322f6c1f%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158951495839859%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jFqDCfrpfhU%2BXW1eekc7oTea7dkF8p0p1gR3eN%2FfLmI%3D&reserved=0 I set as following in my job submission script,
mpiexec_mpt -p %g: -np 4 omplace ./fv3.exe 1
but still getting same error. I think this is because of not building src/Driver. The UFS driver does not have similar code like following,
https://github.com/uturuncoglu/schism/blob/639d57a17f22d33d82d422b494e41c1cd99cd29e/src/Driver/schism_driver.F90#L91https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Futuruncoglu%2Fschism%2Fblob%2F639d57a17f22d33d82d422b494e41c1cd99cd29e%2Fsrc%2FDriver%2Fschism_driver.F90%23L91&data=05%7C01%7Cyjzhang%40vims.edu%7C18d0a07b4a9c4ebaffca08db322f6c1f%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158951495839859%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uZKAf6mQNHeiBU8tbsKH%2FzTeinCK1ygGk6dvmPH3T10%3D&reserved=0
I think we make this as an option in ESMF config file (under OCN_attributes:: group) and pass to the model with this way. I could modify the schism cap but maybe you might want to follow different approach. I think this was not used with the exiting CoastalApp since it was building with OLDIO. Anyway, let me know what you think. We could also open an another ticket for this issue.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1492634502&data=05%7C01%7Cyjzhang%40vims.edu%7C18d0a07b4a9c4ebaffca08db322f6c1f%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158951495839859%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tU03dIj8A0jzqV0Y7vyvtcLCulo%2BX%2BIqD6Hgcecl7Ik%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ753CGOFYIBZFPYNYLW65EOTANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C18d0a07b4a9c4ebaffca08db322f6c1f%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638158951495839859%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iQmNjxCO9aArYsP%2B8nCgrmj8Wp8gAJmNvDbp9vQPXXQ%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 Sure. That sounds fine.
Go ahead with making that an option. We did not so far because in principle none of the models should do I/O, but rather a dedicated I/O server....
@platipodium you mean having an option in ESMF config file (in our case nems.configure
). If so, I could easily implement to see how it works.
@platipodium @josephzhang8 I have implemented a way to get nscribes
from nems.configure. It is in the following fork and branch,
https://github.com/uturuncoglu/schism-esmf/tree/feature/coastal_app
you could see diff in here,
but it seems that the model is hanging in MeshCreate call. In my case the configuration uses 4 core and I set nscribes
to 1. So, do I need to assign 1 more processor to the application for I/O? It was using 4 task but maybe I need to use 5 with new I/O. Anyway, let me know what you think?
I also realized that you did not implement the finalize routine for SCHISM and if I understand correctly from following code,
The new IO has also some code that needs to be run during finalization. Anyway, I am not sure this is an urgent issue but I think that you need to be aware of it.
Okay. I tried with 5 task and still failing. Maybe I missed some code that needs to be ported from SCHISM to cap. Anyway, continue to look at it.
I also tried to print out task_id
s
0: task_id = 1
1: task_id = 1
2: task_id = 1
3: task_id = 2
It is something like following. Maybe it is hanging because only task_id = 1 calls schism_init
and last one calls scribe_init
. So, definitely there is some logic over there that I did not catch yet.
Hi Ufuk:
If you did not specify iof_hydro(25) in your param.nml, the code's default is on (1) b/c this is needed for visIT. You can turn it off explicitly, or increase nscriebs to 2.
RE: scribe finalize, I did not add any code b/c the last statement in the main program should take care of that.
call schism_main call parallel_finalize
Does this make sense? Thx.
-Joseph
Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466
From: Ufuk Turunçoğlu @.> Sent: Monday, April 3, 2023 4:52 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@platipodiumhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fplatipodium&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AIxSDyX7kqC7AaUGMUoU3d8bWOYR8Mj%2FWtdDlizFEW0%3D&reserved=0 @josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BUgDvcs8ooHqe5MLWIBBJjq4Vds5peA5BE0AdGs7ouk%3D&reserved=0 I have implemented a way to get nscribes from nems.configure. It is in the following fork and branch,
https://github.com/uturuncoglu/schism-esmf/tree/feature/coastal_apphttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Futuruncoglu%2Fschism-esmf%2Ftree%2Ffeature%2Fcoastal_app&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=x%2BJO3xvpDAXtkGQ%2FIS5OvvM7HOFmC2%2BA%2FkUXGwEk%2Ftc%3D&reserved=0
you could see diff in here,
https://github.com/schism-dev/schism-esmf/compare/master...uturuncoglu:schism-esmf:feature/coastal_app?expand=1https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism-esmf%2Fcompare%2Fmaster...uturuncoglu%3Aschism-esmf%3Afeature%2Fcoastal_app%3Fexpand%3D1&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DiIvE1AWM5BDmB0yvrOb1Mfavc1GZUEkoM2Sx7yoiHk%3D&reserved=0
but it seems that the model is hanging in MeshCreate call. In my case the configuration uses 4 core and I set nscribes to 1. So, do I need to assign 1 more processor to the application for I/O? It was using 4 task but maybe I need to use 5 with new I/O. Anyway, let me know what you think?
I also realized that you did not implement the finalize routine for SCHISM and if I understand correctly from following code,
https://github.com/uturuncoglu/schism/blob/639d57a17f22d33d82d422b494e41c1cd99cd29e/src/Driver/schism_driver.F90#L166https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Futuruncoglu%2Fschism%2Fblob%2F639d57a17f22d33d82d422b494e41c1cd99cd29e%2Fsrc%2FDriver%2Fschism_driver.F90%23L166&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sEYUFVqXIHlrQ4nR30btoNF3IaACdcoWMeb67gYq6Xg%3D&reserved=0
The new IO has also some code that needs to be run during finalization. Anyway, I am not sure this is an urgent issue but I think that you need to be aware of it.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1494964586&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FTcwhkGhd1vSi0Go0%2FETHU8C8%2Be4gKzxDfXglqXlxOM%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ4UTDXHUSIBW33RDNTW7MZ73ANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C4eed5e754d8b40f1d11b08db34854d97%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161519379661183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=nKQpkDv9qxta0vG185ylPOhdl25tiMjB8AWaFIAVal8%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
I suspect there is something we need to add for the cap under new I/O. Could u try directly running it without cap, i.e. SCHISM stand-alone? This should definitely work...
-Joseph
Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466
From: Ufuk Turunçoğlu @.> Sent: Monday, April 3, 2023 5:13 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
I also tried to print out task_id s
0: task_id = 1
1: task_id = 1
2: task_id = 1
3: task_id = 2
It is something like following. Maybe it is hanging because only task_id = 1 calls schism_init and last one calls scribe_init. So, definitely there is some logic over there that I did not catch yet.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1494986504&data=05%7C01%7Cyjzhang%40vims.edu%7Cdd65e5bbda7f4cca1f8f08db34882a02%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161531648677645%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=14agq4XD4Z37vGJ5HC0%2BIzWESbb7lzFHnPaFnLoUz7E%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ73HQNMXHXOIQXOPETW7M4MTANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7Cdd65e5bbda7f4cca1f8f08db34882a02%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161531648834054%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vhR%2Bp4M984J8HJwoshGwa99dPJxxukGb4bZYH8yj%2BP0%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@josephzhang8 In my case, I have following,
iof_hydro(25) = 0 !horizontal vel vector [m/s]
So, it think I need to use scribe = 1
for this configuration. I started to think about the MPI Communicator. Maybe subset of it needs to passed to cap but not sure. I am looking to schism_mpi_comm
at this point. I did not try to run the model standalone without cap with new I/O. CoastalApp is using old I/O by default.
Okay. I think I found the issue, there are some logic in the following code,
and sets last task (if you set scribe = 1, it could be more based on this number) as I/O task. I think we need to create sub communicator for the component and use this sub communicator (that excludes the I/O tasks) for cap.
Little bit down more interesting things are happening,
So, there could be a communicator mismatch issue between model and the cap. Not sure.
Maybe Carsten, you and I need to meet on this? I need to look at the relevant cap code... thx.
-Joseph
Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466
From: Ufuk Turunçoğlu @.> Sent: Monday, April 3, 2023 5:45 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
Little bit down more interesting things are happening,
https://github.com/uturuncoglu/schism/blob/639d57a17f22d33d82d422b494e41c1cd99cd29e/src/Core/schism_msgp.F90#L415https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Futuruncoglu%2Fschism%2Fblob%2F639d57a17f22d33d82d422b494e41c1cd99cd29e%2Fsrc%2FCore%2Fschism_msgp.F90%23L415&data=05%7C01%7Cyjzhang%40vims.edu%7C87eb46081887434e861408db348cb5f7%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161551180129866%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oKSKinGNlzwe10fN%2B4helW9padVvNpoHj0CCIdAGGuM%3D&reserved=0
So, there could be a communicator mismatch issue between model and the cap. Not sure.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1495024639&data=05%7C01%7Cyjzhang%40vims.edu%7C87eb46081887434e861408db348cb5f7%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161551180129866%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LnwYM8Ya425jct0F%2BMkvhcCdQ%2BYAqdBKDXC5g4ckjT8%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ3CCPFH3WDE2OL7AQ3W7NAGVANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7C87eb46081887434e861408db348cb5f7%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638161551180129866%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=spgx9a4XR4eQdUr5SttXAyxk1A2n%2BzAy%2F5aaBKET%2BZw%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
Let me investigate little bit more. If I could not fix it, we could meet about it. Testing new I/O without coupling could be also beneficial. At least, it eliminates some possibilities. I'll try to run that case too.
@pvelissariou1 I need data for 2008-08-23 to use under CDEPS ATMMESH data mode. If you don't mind could you send me the data (forecast length is 120 hours). If you send me some information, then I could create the data by myself.
As I see from the netcdf history. The data is downloaded from NCAR - CISL RDA. I checked CFSv2 (https://rda.ucar.edu/datasets/ds094.0/) and I think it does not go back to 2008. Maybe we need to use another dataset such as ERA5 etc.
Dear @uturuncoglu thanks for your analysis. I am not very experienced with splitting communicators, and I don't believe we need to do so in the cap, as the resources for the cap should be allocated by the driver, giving the cap/component a set subset of MPI_COMM_WORLD to operate on.
If there is a split within schism to separate out I/O from compute, this should also not affect the cap. I may be entirely wrong, though, and of course we can make any necessary changes.
@uturuncoglu So far there was no need to do anything in a Finalize() routine from the side of the cap, but we (I) can for sure implement this.
What are the things needed in Finalisze() and how do you approach this? In MOSSCO, we tagged every deep object with a "creator" attribute when this object was created, such that we could easily traverse through all objects of component in Finalize(), destroying everything tagged with the same "creator" attribute.
That is very MOSSCO-specific, so I wonder how Coastalapp/ufs-coastal would approach this. I there an implicit tagging of who created an object already in NUOPC infrastructure?
@uturuncoglu @josephzhang8 I reviewed https://github.com/schism-dev/schism/compare/master...uturuncoglu:schism:feature/coastal_app?expand=1.
It seems fine (thank you for the NEtCDF elaboration!). We did not previously implement this as building the driver pschism
did not hurt. For the cap, we would only use the SCHISM libraries (libhydro, libcore ..., repackaged into one libschism) anyway. The naming BLD_STANDALONE
may have to be reconsidered (at a later stage). It would be nice to have this along the already more established line of USE_XXX
, possibly USE_STANDALONE=ON
or USE_DRIVER...
@platipodium I'll discuss with ESMF core team about handling I/O. The PEs that only do I/O might need to be defined as I/O or write component (like UFS) but I am not sure that is the beast approach. I think supporting new I/O capability is not urgent at this point. Anyway, I'll update you about it and may be it would be nice to open a ticket in SCHISM side about it to keep track of it.
I think it is more important when you use new I/O since it requires to call specific routine in the finalize step. I am not sure how I/O works but in finalize it might write some information to the file/s. Under ufs-coastal each component is responsible to call their own finalize routine. So, SCHISM also needs to implement it with its own way.
At the moment we don't have anything to finalize in the scribe I/O part, but we can always add something there like you said. Note there is a mpi_barrier call to make sure scribe and compute processes go into mpi_finalize together.
-Joseph
Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466
From: Ufuk Turunçoğlu @.> Sent: Tuesday, April 4, 2023 12:01 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@platipodiumhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fplatipodium&data=05%7C01%7Cyjzhang%40vims.edu%7Cd54fa65a5fce4d6085a908db3525b9d6%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638162208390491968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fhFW%2BRQ0r5oulOKaKmSUTD2Ecg1h%2BhxkbR01dFN5eKQ%3D&reserved=0 I'll discuss with ESMF core team about handling I/O. The PEs that only do I/O might need to be defined as I/O or write component (like UFS) but I am not sure that is the beast approach. I think supporting new I/O capability is not urgent at this point. Anyway, I'll update you about it and may be it would be nice to open a ticket in SCHISM side about it to keep track of it.
I think it is more important when you use new I/O since it requires to call specific routine in the finalize step. I am not sure how I/O works but in finalize it might write some information to the file/s. Under ufs-coastal each component is responsible to call their own finalize routine. So, SCHISM also needs to implement it with its own way.
- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1496230017&data=05%7C01%7Cyjzhang%40vims.edu%7Cd54fa65a5fce4d6085a908db3525b9d6%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638162208390648192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FBkfbYGGwSjOp7xOLAaUlFMGKKwsCHZxbE0mHd4tIwQ%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ5QCYNSXMV6FYWIZNLW7RASFANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7Cd54fa65a5fce4d6085a908db3525b9d6%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638162208390648192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hxlmUVmgwt69eYgMnmoTmybQt6bVkL2I9K3OEWh6lu4%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
@Ufuk The data for 2008 (Ike) are in /work/noaa/nosofs/pvelissa/for_Ufuk_atm_data/Ike_CFSR.nc This dataset covers the whole globe (0.5 degree resolution). Somehow the subsetting functionality is not currently working at rda.ucar.edu. Let me know if this dataset works for you.
Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***
On Tue, Apr 4, 2023 at 11:05 AM Joseph Zhang @.***> wrote:
At the moment we don't have anything to finalize in the scribe I/O part, but we can always add something there like you said. Note there is a mpi_barrier call to make sure scribe and compute processes go into mpi_finalize together.
-Joseph
Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466
From: Ufuk Turunçoğlu @.> Sent: Tuesday, April 4, 2023 12:01 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@platipodium< https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fplatipodium&data=05%7C01%7Cyjzhang%40vims.edu%7Cd54fa65a5fce4d6085a908db3525b9d6%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638162208390491968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fhFW%2BRQ0r5oulOKaKmSUTD2Ecg1h%2BhxkbR01dFN5eKQ%3D&reserved=0> I'll discuss with ESMF core team about handling I/O. The PEs that only do I/O might need to be defined as I/O or write component (like UFS) but I am not sure that is the beast approach. I think supporting new I/O capability is not urgent at this point. Anyway, I'll update you about it and may be it would be nice to open a ticket in SCHISM side about it to keep track of it.
I think it is more important when you use new I/O since it requires to call specific routine in the finalize step. I am not sure how I/O works but in finalize it might write some information to the file/s. Under ufs-coastal each component is responsible to call their own finalize routine. So, SCHISM also needs to implement it with its own way.
- Reply to this email directly, view it on GitHub< https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Foceanmodeling%2Fufs-coastal%2Fissues%2F2%23issuecomment-1496230017&data=05%7C01%7Cyjzhang%40vims.edu%7Cd54fa65a5fce4d6085a908db3525b9d6%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638162208390648192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FBkfbYGGwSjOp7xOLAaUlFMGKKwsCHZxbE0mHd4tIwQ%3D&reserved=0>, or unsubscribe< https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ5QCYNSXMV6FYWIZNLW7RASFANCNFSM6AAAAAAWNY76MU&data=05%7C01%7Cyjzhang%40vims.edu%7Cd54fa65a5fce4d6085a908db3525b9d6%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638162208390648192%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hxlmUVmgwt69eYgMnmoTmybQt6bVkL2I9K3OEWh6lu4%3D&reserved=0
. You are receiving this because you were mentioned.Message ID: @.**@.>>
— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/2#issuecomment-1496237833, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP6J5AX6DCQ2TONF2JLW7RBFJANCNFSM6AAAAAAWNY76MU . You are receiving this because you were mentioned.Message ID: @.***>
@pvelissariou1 Thanks. I will try with that too. It seems I could provide ERA5 data now which allow me to test the mediator.
@platipodium @josephzhang8 @saeed-moghimi-noaa @pvelissariou1 Okay. I could successfully run ike_shinnecock.atm2sch
(CDEPS+SCHISM) test cases with connectors. I did not check the results yet since I have still issue with analyzing the results. I'll also define this case as RT under UFS Weather Model.
Anyway, I also tried to test CMEPS and as I expected I am getting same error with ADCIRC. Since SCHISM also provides the mesh and fields on nodes it creates incompatibility issue with CMEPS. Anyway, as I remember there was an option in the SCHISM side that uses elements other then nodes. Right? Is it possible to activate that option again. It could be runtime option in the SCHISM cap. Anyway let me know what you think and if you need we could have a call about it.
20230404 145539.068 ERROR PET1 ESMF_FieldRegrid.F90:4102 ESMF_FieldRegridGetArea Invalid argument - Can't currently calculate area on a mesh location other than elements
20230404 145539.068 ERROR PET1 med.F90:2323 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 med.F90:1686 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 MED:src/addon/NUOPC/src/NUOPC_ModelBase.F90:1639 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2577 Invalid argument - Phase 'IPDv03p7' Initialize for modelComp 3: MED did not return ESMF_SUCCESS
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2408 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2192 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:463 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS.F90:386 Invalid argument - Aborting UFS
20230404 145539.068 INFO PET1 Finalizing ESMF
That's great to know, Ufuk.
Carsten can resurrect the code using elem based partitioning. As I explained, this is the native partitioning used by SCHISM, and we had to change it at the request of Robert O. to get the cap working. @@.**@.>: let me know if you need my help in the routine. Thx.
-Joseph
Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466
From: Ufuk Turunçoğlu @.> Sent: Tuesday, April 4, 2023 5:03 PM To: oceanmodeling/ufs-coastal @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] SCHISM integration (Issue #2)
[EXTERNAL to VIMS received message]
@platipodiumhttps://github.com/platipodium @josephzhang8https://github.com/josephzhang8 @saeed-moghimi-noaahttps://github.com/saeed-moghimi-noaa @pvelissariou1https://github.com/pvelissariou1 Okay. I could successfully run ike_shinnecock.atm2sch (CDEPS+SCHISM) test cases with connectors. I did not check the results yet since I have still issue with analyzing the results. I'll also define this case as RT under UFS Weather Model.
Anyway, I also tried to test CMEPS and as I expected I am getting same error with ADCIRC. Since SCHISM also provides the mesh and fields on nodes it creates incompatibility issue with CMEPS. Anyway, as I remember there was an option in the SCHISM side that uses elements other then nodes. Right? Is it possible to activate that option again. It could be runtime option in the SCHISM cap. Anyway let me know what you think and if you need we could have a call about it.
20230404 145539.068 ERROR PET1 ESMF_FieldRegrid.F90:4102 ESMF_FieldRegridGetArea Invalid argument - Can't currently calculate area on a mesh location other than elements
20230404 145539.068 ERROR PET1 med.F90:2323 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 med.F90:1686 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 MED:src/addon/NUOPC/src/NUOPC_ModelBase.F90:1639 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2577 Invalid argument - Phase 'IPDv03p7' Initialize for modelComp 3: MED did not return ESMF_SUCCESS
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2408 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2192 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:463 Invalid argument - Passing error in return code
20230404 145539.068 ERROR PET1 UFS.F90:386 Invalid argument - Aborting UFS
20230404 145539.068 INFO PET1 Finalizing ESMF
- Reply to this email directly, view it on GitHubhttps://github.com/oceanmodeling/ufs-coastal/issues/2#issuecomment-1496602668, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFBKNZ2HYL7RMB45CI3Z6CTW7SEBXANCNFSM6AAAAAAWNY76MU. You are receiving this because you were mentioned.Message ID: @.**@.>>
@platipodium @saeed-moghimi-noaa @pvelissariou1 I am creating this issue to communicate the SCHISM related developments. I am planing to do the same for each component. So, we could focus specific component in each issue. Anyway here is my update about the ongoing development regarding to SCHISM:
feature/coastal_app
branch.SCHISM/src/CMakeLists.txt
file and add new option likeBLD_STANDALONE
. This isON
by default and will not change anything interns of existing functionality but when I build SCHISM under UFS I am setting it toOFF
since I don't want to build Driver and finding libraries (they are provided by UFS). I tried to use the exiting build system as much as possible to create SCHISM-Interface under UFS but we could change the design in the later stage of the project. You could see the changes in the following link, https://github.com/schism-dev/schism/compare/master...uturuncoglu:schism:feature/coastal_app?expand=1*shinnecock*
but I could not use them without having ESMF Mesh file for the atmospheric forcing and also 2d forcing fields (CDEPS requires those). As a workaround, I could go with the CFS data that are provided by @pvelissariou1 for theflorence_hsofs.atm2adc
and used by new CDEPS mode (ATMMESH
) but I am not sure that will work with the SCHISM configuration or not. So, I need some guidance to create test case to test SCHISM build.