search

oceanmodeling / ufs-weather-model

This repo is forked from ufs-weather-model, and contains the model code and external links needed to build the UFS coastal model executable and model components, including the ROMS, FVCOM, ADCIRC and SCHISM plus WaveWatch III model components.
https://github.com/oceanmodeling/ufs-coastal-app
Other
2 stars 3 forks source link

modified ADCIRC-interface/CMakeLists.txt to support Python & Bash for the generation of the version file #39

Closed pvelissariou1 closed 4 months ago

pvelissariou1 commented 4 months ago

modified ADCIRC-interface/CMakeLists.txt to allow support for both python and bash scripts for the generation of the version file.

Recent ADCIRC commits have changed the way the version.F is generated. We need to support both ways (python and Bash)

uturuncoglu commented 4 months ago

@pvelissariou1 I think we also need to update ADCIRC right? If you don't mind could you create another PR in ADCIRC side that syncs our branch with the upstream main. You could also put link of that PR to the description of this one.

Then we could check the configuration agains the exiting baseline. Wo, we need to run coastal_ike_shinnecock_atm2adc and it needs to pass (if we don't know any answer changed changes in the model side).

We have baseline on Hercules. Here are the baseline directories,

RT directory: /work2/noaa/nems/tufuk/RT
Baseline Directory: /work2/noaa/nems/tufuk/RT/NEMSfv3gfs/develop-20240126

So, I think if you point /work2/noaa/nems/tufuk/RT in your rt.sh and run the coastal_ike_shinnecock_atm2adc test. It will automatically check against the baseline.

pvelissariou1 commented 4 months ago

@uturuncoglu Accept this PR as it fixes the version issue from the UFS-Coastal side. It doesn't affect anything in ADCIRC side. I am working on submitting a PR to ADCIRC to include fixes in nuopc and updates from Dam in adcprep. Then we can sync. I'll check against the baseline.

uturuncoglu commented 4 months ago

@pvelissariou1 Okay. That sounds fine. It seems that this will work old and new version of the ADCIRC.