uturuncoglu commented 1 year ago

I am creating new issue for FVCOM integration. So, we could keep communicating about integration issues that we might have.

pvelissariou1 commented 11 months ago

Ufuk, you need to download the data as I pointed out in my previous email. After unarchiving the data, the file you are looking for is at comm/atm/FVCOM I think. Copy the file sww3 into your test folder and rename it accordingly. I think you also need to copy the other FVCOM files from comm/data/FVCOM, look at the .nml file.

On Tuesday, August 1, 2023, Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 I am trying to run scituateharbor.atm2fvc at this point but I think sciww3_forcing.nc is missing. This is used by ATMMESH right? If so and if it is vdercotral file. Could you provide me the original dataset (on lat-lon grid)?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.< https://ci3.googleusercontent.com/proxy/CAzzi82rXQq7foIfmoDLCS2_sX3WjZU0bqRdN5rznVIgKRhiKrmWTwGx_hUk7VXtEKhCf_F0qoFm3bU6YlIbpkmadl2il5u4lxhALJ4QTQqBuvQQH6yM7bMCVL9SRE4X5IiNauZM08LgC0woms24mcu1ysHT9OCMS3Da0GV6ez8ZGY6Q_Hm9sJNxAj0OXSfZxyzQ0fjpDsN35ZgRmk-WRiTMsPdQgmdh9ewGcha2M1nWPJbdlg=s0-d-e1-ft#https://github.com/notifications/beacon/APC7TP2F55PZPQ6QMAHZ5M3XTEUUZA5CNFSM6AAAAAAY3IRNIOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTC7PEJA.gif>Message ID: @.***>

-- Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

uturuncoglu commented 11 months ago

@pvelissariou1 BTW, it seems that fvcom_name is not ingested in the FVCOM cap and the code crashes in the initialization. I think it needs to be ingested with NUOPC AttributeGet call. I could do it but I just want to be sure about it.

uturuncoglu commented 11 months ago

@pvelissariou1 I downloaded the file as you told but there is no comm/atm/FVCOM folder in it.

pvelissariou1 commented 11 months ago

Hi Ufuk,

The files are in: comm/data/atm/sci_ww3_forcing20220621.nc comm/data/fvc/sci*

You need to copy comm/data/atm/sci_ww3_forcing_20220621.nc to input/sciww3_forcing.nc and comm/data/fvc/sci_nest_20220621.nc to input/sci_nest.nc comm/data/fvc/sci_restart_20220621.nc to input/sci_restart_20220621.nc

Thanks Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Tue, Aug 1, 2023 at 11:42 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 I downloaded the file as you told but there is no comm/atm/FVCOM folder in it.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1660711886, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP4R3R4JGNFCCWHAQJDXTEWVPANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

pvelissariou1 commented 11 months ago

Hi Ufuk,

I believe "fvcom_name" needs to be moved in "config.rc" and be read by the cap from there as you said. Please do that.

Thanks Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Tue, Aug 1, 2023 at 11:36 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 BTW, it seems that fvcom_name is not ingested in the FVCOM cap and the code crashes in the initialization. I think it needs to be ingested with NUOPC AttributeGet call. I could do it but I just want to be sure about it.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1660695917, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP4HMRZLIBP4O5EFGH3XTEWAVANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Thanks. Do you have 2d version of comm/data/atm/sci_ww3_forcing_20220621.nc. This is node based and CDEPS requires it in lat-lon format.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> Ufuk, I'll try to create a lat/lon file, otherwise I will talk to Jianhua.

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Tue, Aug 1, 2023 at 2:02 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Thanks. Do you have 2d version of comm/data/atm/sci_ww3_forcing_20220621.nc. This is node based and CDEPS requires it in lat-lon format.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1660915181, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TPYD5P5BVZDU6KFBV4TXTFHE3ANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 BTW, is coastal_ike_shinnecock.atm2ww3 configuration consistent with atm2sch. As I remember we were trying to make them consistent in terms of simulation period to use same dataset but I could not be sure. If not, if you could that would be great.

pvelissariou1 commented 11 months ago

Ufuk, I will work on all these today. I'll keep you posted.

Takis

On Tuesday, August 1, 2023, Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 BTW, is coastal_ike_shinnecock.atm2ww3 configuration consistent with atm2sch. As I remember we were trying to make them consistent in terms of simulation period to use same dataset but I could not be sure. If not, if you could that would be great.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.< https://ci4.googleusercontent.com/proxy/HAwG663ZR5EE3JtLA47DE0N7NASaHCB0RKvmJX40-fcOcjn1v63YuyI8VUyLXC-sxkNuS4k2XnUbEZO-_ReTjtoyE64l4ZYEtS7LO3r1by6hMRQ8_ZqCckqCjwkzf9-5cmmRQT_cdtiaYfyRXH0nwmVJAJ95SA8RXsUBpD9MpnbjT8D3qLktftEw72LmILah_hCHLSswctPnRvK4XlKY_7jcVi8HeuL9XTBj_mWXpnVFW0Ij4w=s0-d-e1-ft#https://github.com/notifications/beacon/APC7TP26HE6ZCRXIUPZVWSDXTFOODA5CNFSM6AAAAAAY3IRNIOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTDADPLS.gif>Message ID: @.***>

-- Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

uturuncoglu commented 11 months ago

@pvelissariou1 Thank you. Sorry about lots of issue. Best

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> Ufuk I created a regular lat-lon atmospheric file for the "scituateharbor.atm2fvc" case. The file is in input/sciww3_forcing_STR.nc (also I included input/sciww3_forcing.nc) that is, in CoastalApp-testsuite/scituateharbor.atm2fvc/run/input folder.

I am not sure if this is going to work. I emailed @Jianhua Qi @.***> to see if he has the original file (data) where he generated sciww3_forcing.nc from.

I am also working on the other requests.

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Tue, Aug 1, 2023 at 5:36 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Thanks you. Sorry about lots of issue. Best

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1661190921, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP6UO5372T4TMZWNOE3XTGAGPANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Thanks. Sorry for all extra works. I'll check this file and let you know.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> Ufuk, the only cases I see inconsistencies between WW3 and OCN are the schism test cases with ww3. I checked the ADCIRC/WW3 cases for shinnecock and the simulation times match. I will fix the schism cases later today and make sure that WW3 outputs the results in NetCDF format. I'll keep you posted. Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Tue, Aug 1, 2023 at 11:37 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Thanks. Sorry for all extra works. I'll check this file and let you know.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1661483727, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP2FHVMPXOGUT6XVWVDXTHKP5ANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Thanks. Cheyenne and Orion are both down today. So, I am switching to other projects and get back to work on Coastal tomorrow.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> No worries, I'll talk to you tomorrow.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Wed, Aug 2, 2023 at 2:45 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Thanks. Cheyenne and Orion are both down today. So, I am switching to other projects and get back to work on Coastal tomorrow.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1662875393, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TPYPZV4EV47DHQVTUZLXTKU5NANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 I fixed the cap to get fvcom_name but I have another problem. The scituateharbor.atm2fvc case is failing with following error,

 0:  %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 0:  FVCOM Fatal Error!
 0:  The start year in domain sci does not match with the NUOPC/ESMF start year.
 0:  Stopping FVCOM
 0:  %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

When I checked the SYEAR and S_YEAR_I. The SYEAR is 0 and S_YEAR_I is 2022 as expected. I found that SYEAR is defined in the following file,

FVCOM-interface/FVCOM/nuopc/mod_driver.F90:   integer :: syear, smonth, sday, shour, sminute, ssecond

but it seems it is never used and so the value is 0. Anyway, I wonder if this cap is working or tested before. Maybe I am missing something in here. Please let me know what you think?

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> The cap has been used and working???? I remember, I have run the FVCOM cases before (not the 2D). Now, in CoastalApp/NEMS/src/MAIN_NEMS.F90, Jianhua has defined two code blocks where the syear and others are set:

   USE module_NEMS_Rusage,ONLY: NEMS_Rusage

ifdef FRONT_FVCOM

   USE mod_driver,  ONLY: syear, smonth,sday, shour, sminute, ssecond

endif

and

ifdef FRONT_FVCOM

  SYEAR   = YY
  SMONTH  = MM
  SDAY    = DD
  SHOUR   = HH
  SMINUTE = MNS
  SSECOND = SEC

endif

These shouldn't be there to start with. Can you check this?

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 12:43 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 I fixed the cap to get fvcom_name but I have another problem. The scituateharbor.atm2fvc case is failing with following error,

0: %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% 0: FVCOM Fatal Error! 0: The start year in domain sci does not match with the NUOPC/ESMF start year. 0: Stopping FVCOM 0: %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

When I checked the SYEAR and S_YEAR_I. The SYEAR is 0 and S_YEAR_I is 2022 as expected. I found that SYEAR is defined in the following file,

FVCOM-interface/FVCOM/nuopc/mod_driver.F90: integer :: syear, smonth, sday, shour, sminute, ssecond

but it seems it is never used and so the value is 0. Anyway, I wonder if this cap is working or tested before. Maybe I am missing something in here. Please let me know what you think?

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1665043244, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP4RYOZHNE3LUC7CMETXTSDYZANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Hmm. Thanks. Since we are using new driver this part is not in ufs-coastal. I think this needs to be in the FVCOM cap not in the NEMS driver. Let me work on it. There is a way to query those information (driver related time information) from the cap. So, I think we just need to add that code to the FVCOM cap. Sorry for questioning the cap and its readiness. I had to think about the NEMS driver. Since, this is model code, I did not think there is a code block in the NEMS driver. Thanks again for your help.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> No worries. Anyway, the FVCOM cap needs to be modified and improved (also for ADCIRC). Let's have FVCOM in UFS-Coastal working somehow and we will take it from there. Tomorrow I'll send you the updated lat-lon atm. forcing data, I need to check what I got from Jianhua first. I'll request to include you in the FVCOM workshop invitation next week. If you have time, please join. I'll present our works for FVCOM in CoastalApp/UFS-Coastal

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 1:09 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Hmm. Thanks. Since we are using new driver this part is not in ufs-coastal. I think this needs to be in the FVCOM cap not in the NEMS driver. Let me work on it. There is a way to query those information (driver related time information) from the cap. So, I think we just need to add that code to the FVCOM cap. Sorry for questioning the cap and its readiness. I had to think about the NEMS driver. Since, this is model code, I did not think there is a code block in the NEMS driver. Thanks again for your help.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1665064355, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP54N4OLOTJ2NROGMQ3XTSGYJANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 If you don't mind could you give me asses to your FVCOM fork. So, I could push cap modifications directly.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> Ufuk, I added you as a collaborator. I Sent you an invitation. Let me know if you can access. Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 11:45 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 If you don't mind could you give me asses to your FVCOM fork. So, I could push cap modifications directly.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1665902154, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP6JL6LL3JFKEJANC6DXTURIHANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Thanks. Do you want to keep FVCOM compatible with the CoastalApp? I could improve the cap but that could break the compatibility.

pvelissariou1 commented 11 months ago

At this point I would like to keep FVCOM compatible with the CoastalApp (you mean the nuopc cap). Why you don't create another branch and do the additional cap updates there?

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 12:05 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Thanks. Do you want to keep FVCOM compatible with the CoastalApp? I could improve the cap but that could break the compatibility.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1665929543, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TPZLSYYQHXUVBOOLTLDXTUTUXANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Okay. No that is fine. We have already too much fork/branch and I don't want to bring another one. I think I could manage it without breaking anything. This could be also used under CoastalApp and you don't need to have those extra code in the NEMS part. Anyway, once it is ready I'll let you know and you could test it under CoastalApp.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> Ufuk, thanks, I agree. I'll try it on both CoastalApp and UFS-Coastal.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 12:31 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Okay. No that is fine. We have already too much fork/branch and I don't want to bring another one. I think I could manage it without breaking anything. This could be also used under CoastalApp and you don't need to have those extra code in the NEMS part. Anyway, once it is ready I'll let you know and you could test it under CoastalApp.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1665956857, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP5DDZOM6YTLKM5VLYDXTUWUVANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 Which variables are need to be exchanged for ATMMESH+FVCOM case. Is it still U, V and P? I am asking because sciww3_forcing_STR.nc file also have evaporation and precipitation (I think used by wet-dry). If so, we need to extend ATMMESH to provide those fields too.

uturuncoglu commented 11 months ago

@pvelissariou1 I could able to run scituateharbor.atm2fvc under ufs-coastal with connector only option but I am getting following error when I introduce the CMEPS,

20230804 172907.857 INFO             PET00 (med.F90:med_meshinfo_create) mesh information extracted from Sa_pslv
20230804 172907.857 INFO             PET00 (med.F90:med_meshinfo_create) mesh information extracted from 

20230804 172907.857 ERROR            PET00 ESMF_Mesh.F90:4754 ESMF_MeshGet Object being used before creation  - Bad Object
20230804 172907.857 ERROR            PET00 med.F90:2350 Object being used before creation  - Passing error in return code
20230804 172907.857 ERROR            PET00 med.F90:1714 Object being used before creation  - Passing error in return code
20230804 172907.857 ERROR            PET00 MED:src/addon/NUOPC/src/NUOPC_ModelBase.F90:1639 Object being used before creation  - Passing error in return code
20230804 172907.857 ERROR            PET00 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2577 Object being used before creation  - Phase 'IPDv03p7' Initialize for modelComp 3: MED did not return ESMF_SUCCESS
20230804 172907.857 ERROR            PET00 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2408 Object being used before creation  - Passing error in return code
20230804 172907.857 ERROR            PET00 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2192 Object being used before creation  - Passing error in return code
20230804 172907.857 ERROR            PET00 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:463 Object being used before creation  - Passing error in return code
20230804 172907.857 ERROR            PET00 UFS.F90:386 Object being used before creation  - Aborting UFS

I need to look at it more detailed. This does not seem to be related with the mesh and probable before that. If I fix this, I could able to see the mesh is fine with CMEPS or not. I'll keep working on it and update you if I have any progress.

uturuncoglu commented 11 months ago

@pvelissariou1 My initial impression after creating mesh visualization is that we will have similar issue with the mesh since it has ghost points that needs to be removed from the mesh. I'll also look at that one.

Screenshot 2023-08-04 at 4 37 16 PM

This is just for proc 0 and 1 but you could see the pink mesh region in the boundary. BTW, it seems that the mesh did not in spherical coordinate but not sure. I need to check it.

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.***> I build the dependencies for FVCOM in CoastalApp through the build.sh script. Please look at the function "compileFVCOMLibs" in CoastalApp/scripts/functions_build. Now for UFS-Coastal this process should be incorporated into the cmake wrapper you are building.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Mon, Jun 5, 2023 at 12:39 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 I am using your fork (main branch) for FVCOM at this point. https://github.com/pvelissariou1/FVCOM.git I wonder if this also builds the dependencies that you were mentioning.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1577207007, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP43WGM6PULPAP5XPB3XJYKTZANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

pvelissariou1 commented 11 months ago

@Ufuk Turuncoglu @.> , @Jianhua Qi @.> I believe only uwnd(U), vwnd(V) and pressure(P) are needed for the 2D case. Jianhua please verify this.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 5:14 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Which variables are need to be exchanged for ATMMESH+FVCOM case. Is it still U, V and P? I am asking because sciww3_forcing_STR.nc file also have evaporation and precipitation (I think used by wet-dry). If so, we need to extend ATMMESH to provide those fields too.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1666229292, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP5OCYX3Y4UV3OO4ZRDXTVX4ZANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

pvelissariou1 commented 11 months ago

Hi Takis,

Yes, FVCOM 2-D model only uses wind variables as surface forcing.

Best, Jianhua

From: Panagiotis Velissariou - NOAA Affiliate @.> Sent: Friday, August 4, 2023 9:31 PM To: oceanmodeling/ufs-coastal @.>; Ufuk Turuncoglu @.>; Jianhua Qi @.> Cc: oceanmodeling/ufs-coastal @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] FVCOM integration (Issue #6)

[EXTERNAL SENDER] @Ufuk @.> , @Jianhua @.> I believe only uwnd(U), vwnd(V) and pressure(P) are needed for the 2D case. Jianhua please verify this.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.**@.>

On Fri, Aug 4, 2023 at 5:14 PM Ufuk Turunçoğlu @.**@.>> wrote:

@pvelissariou1https://github.com/pvelissariou1 Which variables are need to be exchanged for ATMMESH+FVCOM case. Is it still U, V and P? I am asking because sciww3_forcing_STR.nc file also have evaporation and precipitation (I think used by wet-dry). If so, we need to extend ATMMESH to provide those fields too.

— Reply to this email directly, view it on GitHubhttps://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1666229292, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APC7TP5OCYX3Y4UV3OO4ZRDXTVX4ZANCNFSM6AAAAAAY3IRNIM. You are receiving this because you were mentioned.Message ID: @.***>

pvelissariou1 commented 11 months ago

@Jianhua Qi @.***> Thanks Jianhua

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Mon, Aug 7, 2023 at 8:42 AM Jianhua Qi @.***> wrote:

Hi Takis,

Yes, FVCOM 2-D model only uses wind variables as surface forcing.

Best, Jianhua

From: Panagiotis Velissariou - NOAA Affiliate < @.> Sent: Friday, August 4, 2023 9:31 PM To: oceanmodeling/ufs-coastal < @.>; Ufuk Turuncoglu @.>; Jianhua Qi @.> Cc: oceanmodeling/ufs-coastal @.>; Mention @.> Subject: Re: [oceanmodeling/ufs-coastal] FVCOM integration (Issue #6)

[EXTERNAL SENDER] @Ufuk Turuncoglu @.> , @Jianhua Qi @.> I believe only uwnd(U), vwnd(V) and pressure(P) are needed for the 2D case. Jianhua please verify this.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Fri, Aug 4, 2023 at 5:14 PM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 Which variables are need to be exchanged for ATMMESH+FVCOM case. Is it still U, V and P? I am asking because sciww3_forcing_STR.nc file also have evaporation and precipitation (I think used by wet-dry). If so, we need to extend ATMMESH to provide those fields too.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1666229292, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TP5OCYX3Y4UV3OO4ZRDXTVX4ZANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 11 months ago

@pvelissariou1 It seems that FCVOM cap does not accept anything from ATM at this point. All the code related with it is commented out. https://github.com/pvelissariou1/FVCOM/blob/3077f274f5941c2771c80c1b46aa199adae37736/nuopc/fvcom_cap.F90#L383 Why? Do you have any idea?

uturuncoglu commented 11 months ago

@pvelissariou1 Plus section with meteo_forcing. We need to enable them to test this configuration.

uturuncoglu commented 11 months ago

@pvelissariou1 I tried to comment out those sections but it is not working. Some data structures are even not defined etc. So, I think that part of code is not compete. What do we need to do. I could try to fix those but I am not sure it will break anything in their side or not or maybe it removes some feature that they need. Anyway, let me know what you think?

uturuncoglu commented 11 months ago

@pvelissariou1 We also need to activate NVGL variable (store element connections but with global node ids) under FVCOM/src/setup_domain.F if we want to port eliminate_ghost routine from ADCIRC to here. I could list all those issues for you for your presentation and then you could update the developers.

pvelissariou1 commented 10 months ago

@Ufuk, Ufuk the ATM fields were commented out by Jianhua for running his 3D cases. For the 2D case he turned these on in the fvcom nuopc cap. Let's focus on the 2D case for now, I will update CoastalApp with the "fixed" nuopc cap. In other words, the FVCOM cap only works with 2D cases. We need to modify/improve the cap as well as the caps on the other models. I should have checked that.

pvelissariou1 commented 10 months ago

@uturuncoglu Ufuk, yes we need to fix all these issues. May be is a good idea will be to start from scratch (e.g. using prototype codes from the ESMF repos?).

uturuncoglu commented 10 months ago

@pvelissariou1 I think at this point just making 2d case work is the best approach. Since FVCOM inherits lots of cap code from ADCIRC, they both share same issues. It could take time to develop the caps from scratch. Of course, if that is our priority, we could do it.

pvelissariou1 commented 10 months ago

@Ufuk Turuncoglu @.***> Yes I agree, I was just thinking out loud. The rest of the issues you identified need to be fixed. In the presentation today, I'll try to bring these issues, please chime in as you see it fit.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Wed, Aug 9, 2023 at 7:28 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 I think at this point just making 2d case work is the best approach. Since FVCOM inherits lots of cap code from ADCIRC, they both share same issues. It could take time to develop the caps from scratch. Of course, if that is our priority, we could do it.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1671233928, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TPYCV4ETGUTT4EILFFDXUN66HANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 10 months ago

@pvelissariou1 What is our plan with FVCOM? As I remember, you were plaining to update your fork with recent code but not sure. I could try to fix the cap but maybe it is already working in their side. BTW, I am not sure why they had to disable meteo_forcing in different cases. The cap might need to run both 2d and 3d configurations seamlessly. I also noticed that there are lots of check (checking max etc.) in the incoming fields. So, that part of cap might also need cleaning. It might be nice to arrange a meeting with FVCOM developers.

pvelissariou1 commented 10 months ago

@uturuncoglu I will update the cap tomorrow. The cap is not working for the 3D cases of FVCOM we have in the testsuite, so the meteo forcing was commented out. The atmospheric forcing was defined in FVCOM's namelist file that is, the atm. data were not passed via the nuopc cap. For the 2D case we are testing all these fields are uncommented and the atm. data are passed through the nuopc cap (I think I mentioned this in my presentation). Anyway, I'll update the nuopc cap tomorrow and I'll test it on orion. After that I will implement your changes and test again. I'll let you know tomorrow.

pvelissariou1 commented 10 months ago

@uturuncoglu Ufuk, the changes we had in my fork have been merged upstream to the FVCOM github repo. Pending are the changes in the NUOPC cap you made and the commented out lines for the atmospheric forcing. I will send a PR and the coming Friday we will merge those as well. After Friday, I will switch FVCOM in CoastalApp to point to the FVCOM github and delete my fork.

uturuncoglu commented 10 months ago

@pvelissariou1 Thanks. I'll wait until atmospheric forcing part is available and tested. Then, I could start testing FVCOM again. Let me know if you want me to do anything in terms of FVCOM.

pvelissariou1 commented 10 months ago

@uturuncoglu Ufuk, let's wait until Friday. I'll schedule a meeting with the FVCOM developers to discuss the CMEPS/NUOPC issues you have identified. Then, we will take it from there.

uturuncoglu commented 10 months ago

@pvelissariou1 Here is the issues that we faced with FVCOM. We could used them as a reference in the call,

FVCOM ISSUES:

We need to remove ghost elements from mesh to run FVCOM along with CMEPS mediator
- We could use same eliminate_ghost() call developed for ADCIRC, https://github.com/uturuncoglu/adcirc/blob/266c987870971099872ec57a083c52e8f7b71593/thirdparty/nuopc/adc_mod.F90#L425
- This requires to have element connectivity array but holds global node ids
- NV holds the local ids (in MODULE ALL_VARS - src/mod_main.F)
- Maybe NVGL holds the global ids but it is commented in the source code. If it holds global ids, we need to activate it to use under eliminate_ghost()
- We also need to define import and export fields on element location. This requires passing meshloc= ESMF_MESHLOC_ELEMENT argument to ESMF_FieldCreate(). The default is ESMF_MESHLOC_NODE.
At this point we are targeting scituateharbor.atm2fvc (2d case with datm+fvcom) configuration
- The meteo_forcing part is commented in the NUOPC cap. This needs to be fixed
- Also there are some manual range checking for variables such as PRN1, WVNX1, WVNX2.
- Why do we need those checks?
- Is there any specific issue with the cap and requires those checks?
- Which application is used for testing?
We are using following issue to track FVCOM integration
- https://github.com/oceanmodeling/ufs-coastal/issues/6
- https://user-images.githubusercontent.com/1228999/258542416-51db58fb-f460-4067-b713-3342f562b6d7.png (shows overlapped elements)

pvelissariou1 commented 10 months ago

@pvelissariou1 will (a) update the FVCOM nuopc cap to activate the atmospheric forcing part and (b) do some checking cleaning of the code. Also will push the updates to CoastalApp and UFS-Coastal and run the 2D FVCOM test to verify that the changes work as expected.

@uturuncoglu will check the FVCOM source code, when has available time for this project, to see what of the NV* variables can be used to identify the ghost elements to be eliminated during the generation of the ESMF mesh. After this investigation and the possible fixes we will talk with the FVCOM developers again.

uturuncoglu commented 10 months ago

@pvelissariou1 I wonder if you could have time to update FVCOM cap by including atmospheric forcing part and test it. I port solution from ADCIRC to FVCOM but I could not test since atmospheric forcing part is missing in my case and CMEPS is failing. Anyway, let me know when you push the updates.

pvelissariou1 commented 10 months ago

@Ufuk Turuncoglu @.***> Ufuk, FVCOM cap has been updated (my fork). I am trying to run the tests to make sure that the connector works properly. Please go ahead and update the FVCOM/nuopc folder in UFS-Coastal. It should be ok now.

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Physical Scientist - Project Lead cell: (205) 227-9141 email: @.***

On Wed, Aug 30, 2023 at 12:01 AM Ufuk Turunçoğlu @.***> wrote:

@pvelissariou1 https://github.com/pvelissariou1 I wonder if you could have time to update FVCOM cap by including atmospheric forcing part and test it. I port solution from ADCIRC to FVCOM but I could not test since atmospheric forcing part is missing in my case and CMEPS is failing. Anyway, let me know when you push the updates.

— Reply to this email directly, view it on GitHub https://github.com/oceanmodeling/ufs-coastal/issues/6#issuecomment-1698495316, or unsubscribe https://github.com/notifications/unsubscribe-auth/APC7TPZP4V6NUM4FDAIKN5TXX3CJDANCNFSM6AAAAAAY3IRNIM . You are receiving this because you were mentioned.Message ID: @.***>

uturuncoglu commented 10 months ago

@pvelissariou1 Okay. Thanks. Let me test again.

oceanmodeling / ufs-weather-model

FVCOM integration #6

ifdef FRONT_FVCOM

endif

ifdef FRONT_FVCOM

endif

Best, Jianhua