Limit compulsory objects in DataSet dims/data_vars/attrs/coords and distinguish 2D/3D

oceanmodeling / xarray-selafin

An xarray engine for opening Selafin files (TELEMAC)

https://pypi.org/project/xarray-selafin/

The Unlicense

4 stars 2 forks source link

Limit compulsory objects in DataSet dims/data_vars/attrs/coords and distinguish 2D/3D #13

Closed lucduron closed 8 months ago

lucduron commented 8 months ago

What do you think of removing the dimension "plan" for 2D (it would only be available in 3D)?

I would also remove some redondant data:

meshx vs x coords
meshy vs y coords
ipobo2 attribute vs ipobo3 attribute
...

The aim is to be able to write a Selafin file from a more simple DataSet directly. Compulsory data would be : x, y, ikle2 and data_vars. All other data would be optional.

tomsail commented 8 months ago

I like the idea

lucduron commented 8 months ago

I will try to commit something to have a simpler DataSet.