search

oceanmodeling / xarray-selafin

An xarray engine for opening Selafin files (TELEMAC)
https://pypi.org/project/xarray-selafin/
The Unlicense
4 stars 2 forks source link

Make dask an optional dependency #2

Closed pmav99 closed 6 months ago

pmav99 commented 9 months ago

Minor issue, but I am opening the ticket so that I don't forget about it.

Currently, dask is a mandatory dependency of the xelafin backend. Nevertheless dask is an optional dependency of xarray.

My understanding is that it should be possible to develop the backend so that it can work either "eagerly" (without dask) or "lazily" (with dask). For now I guess that we should focus on getting either mode to work, but in the future we should test/support both.

For the record, it might be easier to fix the issues we have with write in the eager mode.

tomsail commented 9 months ago

For the record, it might be easier to fix the issues we have with write in the eager mode.

exactly. I will implement first the "eager" mode and see it fixes the issue with slice indices.

tomsail commented 8 months ago

dask is now optional. But dask hasn't been implemented yet.