Fix `Last Balance Check` checks

oceanprotocol-archive / DAOBot

Web3 Glue for OceanDAO

6 stars 4 forks source link

Closed trizin closed 2 years ago

trizin commented 2 years ago

Changes proposed in this PR:

Fix Last Balance Check checks
Remove balance check in prepareProposalsForSnapshot function, this causes the balances to be checked twice. It is called in prepareNewProposals function in update_funding_round.js file.

idiom-bytes commented 2 years ago

Updates make sense. Am just wondering if there are edge cases around it that should be getting tested.

trizin commented 2 years ago

Feel free to test it on your local! I believe I tested most of the cases. @idiom-bytes

trizin commented 2 years ago

idiom-bytes commented 2 years ago

[Change reverted] Whenever proposals are configured for snapshot Proposals.Prepare(Snapshot Voting Period) => 500 OCEAN check is applied.

Please note: Test execution time has somewhere along the way nearly doubled from ~90s => ~180s.