search

oceanprotocol-archive / bounties

🎣 Bounties for Ocean Protocol
Apache License 2.0
11 stars 0 forks source link

Ocean Bounty : Improve Unit Test Coverage for Keeper Contracts #6

Closed Anirudh2490 closed 5 years ago

Anirudh2490 commented 5 years ago

Improve Unit Test Coverage for Keeper Contracts

How can you help?

We want to improve our unit test coverage and optimize integration tests for our keeper-contracts repo.

What needs to be done?

We are very happy when

Seen this problem before?

Any help solving this is welcome. Feel free to leave any comments and help someone else to solve it. We might airdrop tokens to someone even if not directly completing bounty.

Questions & Reviews

Pull requests will be reviewed by one of the maintainers or long-term contributors. In case of any additional questions feel free to ask in this thread and we will do our best to add the missing info :)

Things to know

The bounty lifecycle process including payout will be managed using Gitcoin. We'll be responding to your questions here, but for discussion and clarification we recommend to join also our Gitter channel where our tech community is accessible. In order to see the PROCN balance in your wallet you'll need to reference the related token contract with address 0xf2aabdd898a0139195b2b5da7387d43a45ded254. If you use a Metamask plugin you'll find the the exact steps here.

Reward

Once the project was reviewed and merged in the master branch, you will receive the reward. PROCN is a proto-Ocean token. Bounty hunters that earn PROCN will be able to convert them 1:1 to Ocean tokens on network launch (currently Ocean Token is valued at 0.20 EUR). Network launch is expected to happen by Mar 31, 2019. Until then PROCN will be locked and non-transferrable in the ETH wallet to which it is delivered to.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 5000.0 PROCN attached to it as part of the Ocean Protocol Foundation fund.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months, 3 weeks ago. Please review their action plans below:

1) nemaniarjun has been approved to start work.

Hey I would like to work on this. I have experience with writing code coverage for Solidity and Js, as I have done similar college assignments and bounties in the past.

Thanks!

Learn more on the Gitcoin Issue Details page.

2) aquiladev has been approved to start work.

I will follow the plan:

  1. Check the contract(s), figure out purpose of contracts, read documentation, check control flow, etc.
  2. Clone repository, sync versions of compiler and dependencies, check that current implementation works
  3. Check coverage, check not covered logic, write unit test, possible refactoring
  4. Repeat step 3 until coverage won't be acceptable
  5. Check integration tests coverage, code relations, write integration test
  6. Repeat step 5 until coverage won't be acceptable
  7. Push code, create PR

Learn more on the Gitcoin Issue Details page.

chalidbdb commented 5 years ago

Welcome @nemaniarjun! Good to have you on bord. If you have any question or get stuck please post in our gitter channel: https://gitter.im/oceanprotocol/Lobby. Happy hunting.

chalidbdb commented 5 years ago

Welcome @aquiladev! We are happy to have you helping us. If you have any question or get stuck please post in our gitter channel: https://gitter.im/oceanprotocol/Lobby.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 5000.0 PROCN has been submitted by:

  1. @aquiladev

@chalidbdb please take a look at the submitted work:

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 5000.0 PROCN attached to this issue has been approved & issued to @aquiladev.

innopreneur commented 5 years ago

Closing this issue as bounty has been merged and bounty reward is paid.