Closed alexcos20 closed 1 year ago
For filtering, the user should use the following env variable:
CONTRACTS_TO_PREDICT: List of ticker-timespan-source pairs to make predictions on, if empty the app will predict on all available pairs. For example: "["BTC/TUSD-5m-binance", "ETH/USDT-5m-uniswap"]"`
This feature is also required for the following repos: https://github.com/oceanprotocol/pdr-trader/issues/1 https://github.com/oceanprotocol/pdr-trueval/issues/6
Perhaps it makes sense to create a module / new repo to avoid code replication.
correct, but if you take a look at the code, it does not do any filtering (https://github.com/oceanprotocol/pdr-predictoor/blob/main/pdr_predictoors/utils/subgraph.py#L16-L57)
Since then, we have added a full spec of describing pairs in https://github.com/oceanprotocol/pdr-private/issues/19#issuecomment-1591330040 and it was implemented in https://github.com/oceanprotocol/pdr-publisher/blob/main/publish.py#L61-L65
So we need to update the code logic to take erc725 keys from graph and do additional filtering
Final decision:
Reopening this, I did not think it would automatically close between repos
when pdr-predictoor starts, we need to be able to filter what pairs to act upon.
ie: We want to predict for btc-tusd on binance and eth-usdt on kraken. We are not interested in eth-usdt on binance (and other pairs)