search

oceanprotocol / list-purgatory

😈 Lists tracking assets and accounts in Purgatory, which has consequences in the Ocean Market UI.
4 stars 9 forks source link

Request to remove retired datasets from the Ocean Marketplace #49

Closed realdatawhale closed 3 years ago

realdatawhale commented 3 years ago

Fixes # .

We are looking to retire the following datasets. We have already announced the retirement of the pool assets on our official Twitter account.

STUTUR-23 https://market.oceanprotocol.com/asset/did:op:312d24dE83610e351A1977EbA8851CeA8D020e1B

MARRAY-61 https://market.oceanprotocol.com/asset/did:op:7c0D0DC5bCACeDf8121047c34bFb0ABeB00d4b19

FIXED PRICE: SALOTT-11 https://market.oceanprotocol.com/asset/did:op:8b4045F37dB438F9761c615e9512c3Bf742e29cf

FIXED PRICE: EGRFIS-84 https://market.oceanprotocol.com/asset/did:op:0e36Caa04EbefC1B2A77620F41e6c343a1d9d660

realdatawhale commented 3 years ago

@jamiehewitt15 , I've tried to do this on my own but couldn't edit it. Not working with GitHub myself, so everything is very new here! My apologies. Hope this helps, so you can copy it in:

"did": "did:op:312d24dE83610e351A1977EbA8851CeA8D020e1B", "reason": "isRetired"

"did": "did:op:7c0D0DC5bCACeDf8121047c34bFb0ABeB00d4b19", "reason": "isRetired"

"did": "did:op:8b4045F37dB438F9761c615e9512c3Bf742e29cf", "reason": "isRetired"

"did": "did:op:0e36Caa04EbefC1B2A77620F41e6c343a1d9d660", "reason": "isRetired"

jamiehewitt15 commented 3 years ago

@realdatawhale I have added them to the purgatory list.

@kremalicious can you review?

kremalicious commented 3 years ago

all good so far, just the reason could be more user friendly as it's showing up over in market in UI. We do not have anything for this case standardized in here, but would suggest "reason": "retired by publisher"

kaimeinke commented 3 years ago

I agree, the "retired" functionality seems like a "must have" to me and it should be different than the classic purgatory request. I should be limited to the specific asset.

realdatawhale commented 3 years ago

all good so far, just the reason could be more user friendly as it's showing up over in market in UI. We do not have anything for this case standardized in here, but would suggest "reason": "retired by publisher"

I agree: "Retired By Publisher" would be great.

I still see them on the UI at the moment, not sure by when they'll be removed. Thanks for your help all!

jamiehewitt15 commented 3 years ago

I still see them on the UI at the moment, not sure by when they'll be removed. Thanks for your help all!

@realdatawhale they will be removed when this PR is merged

jamiehewitt15 commented 3 years ago

@kaimeinke we have an issue for it but it is currently low priority so we will continue using purgatory to retire assets for now.

jamiehewitt15 commented 3 years ago

This requires a code owner review @daneklustig @innoprenuer @sheriff4 @brucepon