search

oceanprotocol / market

🧜‍♀️ THE Data Market
https://market.oceanprotocol.com
Apache License 2.0
190 stars 296 forks source link

Fix footer market stats #1976

Closed bogdanfazakas closed 1 year ago

bogdanfazakas commented 1 year ago

Fixes #1963 .

Changes proposed in this PR:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 9:51am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **dubai-challenge** | ⬜️ Ignored ([Inspect](https://vercel.com/oceanprotocol/dubai-challenge/844728mv2AjP9B4B4zmsv48gGBJy)) | [Visit Preview](https://dubai-challenge-git-fix-footer-values-oceanprotocol.vercel.app) | | Oct 13, 2023 9:51am |
jamiehewitt15 commented 1 year ago

For a second or two, before it loads the data, it shows this weird message about free locked, free allocated. Can we change it so the footer message doesn't show until the data has loaded?

image

bogdanfazakas commented 1 year ago

For a second or two, before it loads the data, it shows this weird message about free locked, free allocated. Can we change it so the footer message doesn't show until the data has loaded?

image

I'll try to quickly add a loader here as well

LoznianuAnamaria commented 1 year ago

I wouldn't spend too much time on this, it's good enough

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit d3e32f10 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.1% (0.0% change).

View more on Code Climate.