restore error check on custom params inputs

oceanprotocol / market

🧜‍♀️ THE Data Market

https://market.oceanprotocol.com

Apache License 2.0

190 stars 296 forks source link

restore error check on custom params inputs #1989

Closed EnzoVezzaro closed 1 year ago

EnzoVezzaro commented 1 year ago

Fixes #1979 .

Changes proposed in this PR:

restore customer parameter error check

HOW TO TEST:

Publish:

Go to Publish
Select "Algorith" asset type
Complete the rest in the form
Check this "This asset uses algorithm custom parameters"
Add, test, review custom parameters' fields

Edit:

Go to an asset with custom parameters you had published
Click on "Edit"
Add, remove, test, review custom parameters
Save changes

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
market	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 31, 2023 9:37pm

1 Ignored Deployment

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 8dda0f06 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2% (0.0% change).

View more on Code Climate.

mariacarmina commented 1 year ago

I can confirm that the issue is fixed right now, I could add the parameters attached to the algorithm. Thank you @EnzoVezzaro! I'll approve.

LucaMilanese90 commented 1 year ago

I noticed this fix broke the custom provider validation (try to remove the default provider and add a new one and you'll see the app crash), you could probably just add !field.name.endsWith('.providerUrl') to the checkError function.

EnzoVezzaro commented 1 year ago

I noticed this fix broke the custom provider validation (try to remove the default provider and add a new one and you'll see the app crash), you could probably just add !field.name.endsWith('.providerUrl') to the checkError function.

Great catch 👍🏽 I created a PR to fix this. Your solution @LucaMilanese90 seems to work, thanks for the help.