oceanprotocol / market

🧜‍♀️ THE Data Market
https://market.oceanprotocol.com
Apache License 2.0
190 stars 296 forks source link

fix hidden field type on edit form load #1993

Closed EnzoVezzaro closed 11 months ago

EnzoVezzaro commented 12 months ago

Changes proposed in this PR:

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:28am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **dubai-challenge** | ⬜️ Ignored ([Inspect](https://vercel.com/oceanprotocol/dubai-challenge/A4w9S3SyvfnYoKoK9qmTzgmMMRy9)) | [Visit Preview](https://dubai-challenge-git-feature-issue-1949-fix-994d89-oceanprotocol.vercel.app) | | Nov 15, 2023 9:28am |
jamiehewitt15 commented 12 months ago

I don't think I have ever experienced the hidden field type issue before, can you suggest some steps for replicating the issue and testing this?

EnzoVezzaro commented 12 months ago

I don't think I have ever experienced the hidden field type issue before, can you suggest some steps for replicating the issue and testing this?

Well, I don't think you'll be able to replicate it after this fix, but you can try what I commented here.

You can try this on the main branch and compare the behaviour with this PR.

jamiehewitt15 commented 11 months ago

Something seems to have broken on this branch, when trying to open one of my assets the app crashes. I'm able to open the same asset on the main branch without any problems.

image

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit a6fa3339 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2% (0.0% change).

View more on Code Climate.

jamiehewitt15 commented 11 months ago

Something seems to have broken on this branch, when trying to open one of my assets the app crashes. I'm able to open the same asset on the main branch without any problems.

Looks like that issue has already been solved on main. It's not happening anymore after pulling the latest changes from main