search

oceanprotocol / market

🧜‍♀️ THE Data Market
https://market.oceanprotocol.com
Apache License 2.0
188 stars 293 forks source link

Only validating custom parameters if algorithm has been selected #2005

Closed jamiehewitt15 closed 9 months ago

jamiehewitt15 commented 9 months ago

Fixes #2003

Changes proposed in this PR:

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
market ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 8:51am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **dubai-challenge** | ⬜️ Ignored ([Inspect](https://vercel.com/oceanprotocol/dubai-challenge/Ei4yxSoHeucufcqCcQmkbdPCbSxH)) | | | Nov 14, 2023 8:51am |
codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit 97db8c9d and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 20.2%.

View more on Code Climate.

bogdanfazakas commented 9 months ago

looks good, i'll approve after we merge #2004 and do one more test