oceanprotocol / ocean-cli

4 stars 5 forks source link

Mnemonic & Private keys are different - Please update readme #22

Closed idiom-bytes closed 11 months ago

idiom-bytes commented 11 months ago

Problem

The readme communicates 2 different concepts as if they're the same.

Set a private key and export it
export MNEMONIC="XXXX"

Mnemonics are the 12-word random keys required to generate private keys. In barge this is preconfigured so you always get the same private keys.

export GANACHE_MNEMONIC=${GANACHE_MNEMONIC:-"taxi music thumb unique chat sand crew more leg another off lamp"}

private-key is the 0x hash associated with a specific EOA

0xfd5c1ccea015b6d663618850824154a3b3fb2882c46cefb05b9a93fea8c3d215

DoD:

mihaisc commented 11 months ago

Thanks for noticing. Change the var to PRIVATE_KEY since we are actually using only the private key. For mnemonic we should use fromMnemonic but doesn't make sense to implement it right now