oceanprotocol / ocean-cli

5 stars 6 forks source link

Override of provider url when running locally barge and ocean-node on macOs #46

Closed FilipMasar closed 6 months ago

FilipMasar commented 7 months ago

Describe the bug There is this hardcoded provider url for macOs https://github.com/oceanprotocol/ocean-cli/blob/main/src/commands.ts#L41 It was added in this commit. Why is that needed?

I am running ocean-node on port 8000 and exporting export PROVIDER_URL='http://127.0.0.1:8000'. But this block of code will override it.

bogdanfazakas commented 7 months ago

This is needed because ocean.js will export the provider url with the barge subnet url, that on macOS is unreachable (same issue can happem if running barge in docker desktop app), so we always have to use http://127.0.0.1:8030 instead of http://172.15.0.4:8030. Will fix this so if the env var is set the provider url will not be override, since forcing a url by setting the env var of Provider or Aquarius url should have the higher priority in terms of usage.