ProviderFees

[alexcos20]

Add providerFees to orders (equivalent of startOrder) and reuse orders

[mihaisc]

It will be stored as a simple string. The client will convert to json as needed

[LoznianuAnamaria]

@bogdanfazakas Are the provider fees integrated on market/ocean.js?

[soonhuat]

@mihaisc wonder if providerFee will be part of Order entity or also part of OrderReuse entity?

[mihaisc]

I think both

[jamiehewitt15]

It will be stored as a simple string. The client will convert to json as needed

Within OPC, providerFee is stored as BigDecimal - are you sure you don't want it to be the same?

[soonhuat]

@jamiehewitt15 if I were right, the providerFee actually is not the cost in numeric, is the whole ProviderFee object index as string https://github.com/oceanprotocol/contracts/blob/e3d75c901aa66c8cfc1ac69b1a339d1356a9f383/contracts/templates/ERC20TemplateEnterprise.sol#L68 OR this event structure https://github.com/oceanprotocol/contracts/blob/e3d75c901aa66c8cfc1ac69b1a339d1356a9f383/contracts/templates/ERC20TemplateEnterprise.sol#L135

[jamiehewitt15]

@jamiehewitt15 if I were right, the providerFee actually is not the cost in numeric, is the whole ProviderFee object index as string

Yeah, that's true 👍

[mihaisc]

Yep, exactly what @soonhuat said, thanks

[alexcos20]

We need to store all values from providerFee event: https://github.com/oceanprotocol/contracts/blob/v4main/contracts/templates/ERC20Template.sol#L133-L142