Human Readable URLs - Githubissues

oceanprotocol / pm

Zenhub needs each issue associated with one repo. This repo is a workaround, to mark issues that span >1 repos.

4 stars 0 forks source link

Human Readable URLs #117

Closed jamiehewitt15 closed 8 months ago

jamiehewitt15 commented 3 years ago

From a marketing and branding perspective it would be great if we could implement human readable URLs.

At the moment publishers have to share very ugly looking URLs when they are promoting their datasets, for example:

https://market.oceanprotocol.com/asset/did:op:7Bce67697eD2858d0683c631DdE7Af823b7eea38

For the publishers it would be better if they could set their own URL slug. For example:

https://market.oceanprotocol.com/asset/dataunion

This would require us to have a mapping between the domain slugs and the dids. It will also require us running a check to see if the slug is unique when the publisher sets it.

calina-c commented 3 years ago

Details to hash out:

what we allow as a slug (e.g. obviously not something that starts with did:op:, something unique, does not contain special characters etc.)
is there any case where we would have duplicate names? e.g. in theory we could have the same slug if on different chains, but that would be cumbersome to maintain
will this reflect inside Aquarius/ES as part of the metadata structure, or would it be a simple mapping on frontend (or frontend-ish level)?
scope and redirects: if we currently build this asset URL somewhere, it will need to be adapted with the slug logic. Is it possible to do this asynchronously on different components?

TimDaub commented 3 years ago

What about ENS names that point to a data token address? E.g. /asset/dataunion.eth or /asset/trepel.eth or whatever the user decides they like.

kremalicious commented 3 years ago

Something came out of prototyping and we accidentally created decentralized publisher URLs in the market based on ENS names, so covering human readable URLs. For the publisher, not the dataset but can't have everything 😄

See https://github.com/oceanprotocol/market/issues/858#issuecomment-921725530

jamiehewitt15 commented 3 years ago

@kremalicious The ENS names work great in the URLs for the profile pages. I can see that there could be a route to doing the same thing for assets in V4. If the asset URL points to the address of the asset NFT then the publisher would have the option to customise the asset URL with ENS

kremalicious commented 3 years ago

not gonna happen in v4 release, we have bigger things to do