Code coverage weak spots

oceanprotocol / pm

Zenhub needs each issue associated with one repo. This repo is a workaround, to mark issues that span >1 repos.

4 stars 0 forks source link

Code coverage weak spots #134

Closed LoznianuAnamaria closed 2 years ago

LoznianuAnamaria commented 2 years ago

Identify any weak code coverage spots, write unit tests covering that functionality

Final review of the V4 main branches

[x] Aquarius - done already. 96% code-coverage
[x] Provider - done already. over 90% code-coverage
[x] Ocean.py - done 93%, please see my last comment on this ticket

calina-c commented 2 years ago

I did a review on both Aquarius and Provider. Aquarius is excellently covered, while Provider could use some improvements but the uncovered code seems to be non-critical.

calina-c commented 2 years ago

Update on ocean.py coverage: I've added coverage and reorganised most modules, except for "models" where the discussion is of "how much" we should test. Our models are pass-throughs to contracts. During the last few weeks, a lot of functionality was deemed not to belong in ocean.py, so we should consider a ticket to analyse what we should keep in ocean.py models, and what to remove.

CC: @AnaLoznianu