search

oceanprotocol / pm

Zenhub needs each issue associated with one repo. This repo is a workaround, to mark issues that span >1 repos.
4 stars 0 forks source link

Create new library for permissions component #142

Closed jamiehewitt15 closed 2 years ago

jamiehewitt15 commented 2 years ago

We need a new front-end implementation of the permissions component in the V4 market.

Previously

There was a permissions component in the market that wrapped all of the various actions that could be restricted by the RBAC server. In the V4 version of the market, the permissions component has been removed.

Proposal:

Create a separate library for the permissions component and the function that calls the RBAC server. This can then be imported in the markets that need it but will not be present in all others. This means that we won't be in the situation where there is code in Ocean Market that is not being used. It should also hopefully be easier to maintain.

LoznianuAnamaria commented 2 years ago

This is a nice feature to have, but we're not going to do it anytime soon. We'll reopen this if it will be needed

jamiehewitt15 commented 2 years ago

Without any frontend implementation of fine-grained permissions it leaves us in a position where we're promoting a feature (on the website and docs) that doesn't work

LoznianuAnamaria commented 2 years ago

I agree with you, that's why I added a task in the docs to remove it for now.

jamiehewitt15 commented 2 years ago

Yep, I've done a PR for that. Are we also removing the page from the website?

jamiehewitt15 commented 2 years ago

No worries, I think it's clear - we'll just remove the links from the website