search

oceanprotocol / pm

Zenhub needs each issue associated with one repo. This repo is a workaround, to mark issues that span >1 repos.
4 stars 0 forks source link

Incorrect c2d `ready` path in ocean.py and df-py scripts #152

Closed MantisClone closed 2 years ago

MantisClone commented 2 years ago

Describe the bug barge creates file $HOME/.ocean/ocean-c2d/ready when c2d components are fully initialized and ready to be used.

https://github.com/oceanprotocol/barge/blob/3a6cc983bb68f6f87ba21a2bfd75f0fe5850c62c/README.md?plain=1#L211

But the ocean.py and df-py scripts wait for $HOME/.ocean/ocean/c2d/ready notice the / instead of -

https://github.com/oceanprotocol/ocean.py/blob/5b53b1713e1a788e7e2b64add381b596f2405c0a/.github/workflows/pytest.yml#L34 https://github.com/oceanprotocol/df-py/blob/2f18f5dc1cda974d2ecdcbcfa426515da7b5e742/.github/workflows/test.yml#L37

MantisClone commented 2 years ago

This was fixed in ocean.py in https://github.com/oceanprotocol/ocean.py/pull/858