oceanprotocol / pm

Zenhub needs each issue associated with one repo. This repo is a workaround, to mark issues that span >1 repos.
4 stars 0 forks source link

Support Balancer V2 #95

Closed trentmc closed 2 years ago

trentmc commented 3 years ago

Background/Motivation

For Ocean V3, we did a friendly fork of Balancer V1, in order to have far lower gas fees in creating pools. (Lower fees via the ERC1167 proxy contract trick.) We reluctantly did this because it meant a larger code base with associated maintenance etc.

Balancer V2 has far lower gas fees. (Lower fees via "one big treasury" with many "pool" interfaces on top.)

We can reasonably expect that Balancer will deploy it to both Eth mainnet and Polygon, by the time we ship Ocean V4 (end of Q2).

The Balancer team has been working on a Balancer JS driver; and will appreciate our input too.

The Balancer team is working to get resources on a Balancer PY driver; and will appreciate our input too. (We can expect to input here more than in the JS driver.)

Spec

By the time we're done:

LoznianuAnamaria commented 3 years ago

Closing this as we are not using Balancer v2 anymore.

trentmc commented 2 years ago

Reopening. We're not using Balancer V2 for initial release of Ocean V4.

However there will be benefits to supporting it at some point:

This needs to be traded off against the complexity increase.

Putting into "long term" for now

kremalicious commented 2 years ago

Not sure why this issue then still exists. By the time we get around "supporting Balancer v2" there will be Balancer v3.

A big win for our community right now would be to simply provide liquidity into OCEAN/ETH pool on Balancer v2 so the v1 pool can be migrated, then talk with their liquidity-committee to provide BAL or even BAL + OCEAN rewards for that pool. Boom, DeFi, tokens locked, circulating supply decreased, gasless trading through Gnosis relayer, everybody happy.

This also applies to Polygon, where the incentives on Balancer v2 are currently higher than on Mainnet. And on Polygon we only have the QuickSwap pool so could use some more liquidity in other tools.

trentmc commented 2 years ago

Closing here, we're tracking this elsewhere - in med/longer term roadmap planning.