oceanprotocol / uploader_backend

Decentralized backend storage API
Apache License 2.0
2 stars 5 forks source link

Clarify responsibilities between the front and the API #40

Closed balessan closed 1 year ago

balessan commented 1 year ago

More of a final specification ticket, than really a bug. There are a few topics not covered in the initial specification and covered in the current code using either environment variables or static keys, which does not make sense:

I initially thought about integrating mutiple new packages/API to handle those, like:

But I am actually wondering if those process are the DBS or the client application reponsibility ?

Need additional inputs here.

jamiehewitt15 commented 1 year ago

The signatures will be handled by the client side of the application. @EnzoVezzaro is working on the UI at the moment, it should be ready soon

EnzoVezzaro commented 1 year ago

I'm working on the dbs.js integration right now into the UI lib. I'll keep you posted.

balessan commented 1 year ago

I'm working on the dbs.js integration right now into the UI lib. I'll keep you posted.

Ok. So just to be clear, can I consider that the client will manage:

Because if so, I can simplify the code once more and consider to be just a proxy.

jamiehewitt15 commented 1 year ago

Yeah @balessan this repo is really just meant to be a proxy. It doesn't need to handle:

I suggest that we close this issue and create separate issues to remove any unnecessary code that's still present.

balessan commented 1 year ago

Let's close it then.

jamiehewitt15 commented 1 year ago

Thanks @balessan, can you create an issue for simplifying the code like you mentioned above, removing any unnecessary code

balessan commented 1 year ago

Thanks @balessan, can you create an issue for simplifying the code like you mentioned above, removing any unnecessary code

Opened as #80 to double-check that nothing unusual remains.