search

ocelot-collab / ocelot

OCELOT is a multiphysics simulation toolkit designed for studying FEL and storage ring-based light sources.
GNU General Public License v3.0
86 stars 58 forks source link

Question about corrector type #209

Closed nightBrise closed 10 months ago

nightBrise commented 10 months ago

Hello, Thanks for your work on this code. I have a question about corrector. In some existing free electron laser devices, the horizontal and vertical corrections are achieved using a same corrector. However, it seems that in the code, only separate Hcor and Vcor can be created. Is there a feature available to use a single corrector for both horizontal and vertical corrections? Thanks advance for your reply!

sergey-tomin commented 10 months ago

Hi,

No, and the reason is following. While it may seem more convenient for simulation purposes, and I understand its usefulness in certain cases. However, Ocelot is also used in the control room for orbit correction, where, in practice, there are always two separate power supplies and two different channels (doocs, epics etc) to control the vertical and horizontal coils even if it is a single physical corrector. That is why to have two object is much more convenient. Creating one class for both corrections would pose challenges in the control room. Thus far, I haven't been able to find a solution that satisfies both cases. That's why I give a little more priority to its usage in the control room.

Sergey.

nightBrise commented 10 months ago

I understand, thank you for your reply.