search

ocelotconsulting / ocelotconsulting.github.io

The Ocelot Consulting LLC Public Website
http://www.ocelotconsulting.com
6 stars 11 forks source link

Consider Changing PR Preview Configuration #183

Closed nerddtvg closed 1 year ago

nerddtvg commented 1 year ago

Netlify has served us well for deployment previews but when builds fail, it's hard to re-run them due to the lack of licensing.

GitHub Pages is coming out with a PR Preview feature but it is currently in Alpha. Can we volunteer for testing access if we report issues?

Can we consider using the deploy-pr-preview Action published here instead?

https://github.com/marketplace/actions/deploy-pr-preview

This Action would deploy the preview as a subfolder under our existing site, one that can be removed after PRs are merged as well. Seems easy to use and decently supported.

nerddtvg commented 1 year ago

Issues possibly related to the failing builds:

https://github.com/npm/cli/issues/4652 https://github.com/nodejs/node/issues/47130#issuecomment-1517171547 (Node v19 but we use v18) https://github.com/node-fetch/node-fetch/issues/1735

nerddtvg commented 1 year ago

Turns out the deploy-pr-preview action is for classic GitHub Pages which deploys off a branch instead of as immutable copies. We need to use something else. A static site running on S3 or Azure Storage would be pretty easy to setup per-PR and destroy when the PR is closed.

Example: https://github.com/marketplace/actions/s3-website-pr