ocelotpotpie / FreedomChat

Liberate your server from the chat-reporting bourgeoisie! Disable chat signing server-side
https://modrinth.com/plugin/freedomchat
GNU General Public License v3.0
204 stars 24 forks source link

FreedomChat 1.3.x won't disable on 1.19.2 and older. #24

Closed Kichura closed 1 year ago

Kichura commented 1 year ago

FreedomChat in modrinth claims to be only compatible with 1.19.3 paper/purpur servers when using the 1.3.x version of it, However because it for some reason is still usable in older server versions; this will cause plugins like ViaVersion to freak out and prevent players from logging in correctly.

In this case, There should be a filtering system considered to prevent causing plugin breakage on older servers that way if possible and perhaps also alert players that craftbukkit/spigot is not supported and instead paper/purpur is recommended.

e-im commented 1 year ago

I had intentionally not added an artificial version limit, but this is no good. The last thing I want is to create annoying to debug issues for other plugins. Thanks for reporting this.

e-im commented 1 year ago

Resolved here https://github.com/e-im/FreedomChat/blob/b9ba6d7fc86c37b40d56b08c962a405b09226a58/src/main/java/ru/bk/oharass/freedomchat/FreedomChat.java#L15-L19

Madis0 commented 1 year ago

Resolved here

https://github.com/e-im/FreedomChat/blob/b9ba6d7fc86c37b40d56b08c962a405b09226a58/src/main/java/ru/bk/oharass/freedomchat/FreedomChat.java#L15-L19

You say it supports 761 but you check for 762?

e-im commented 1 year ago

That is unfortunate. Thanks for pointing it out. The check is correct, the text is wrong. protocol version 761 is for game version 1.19.3.