search

ocerman / zenmonitor

Zen monitor is monitoring software for AMD Zen-based CPUs.
MIT License
251 stars 28 forks source link

Enlarge the window on start so that all rows are visible. #15

Closed j1warren closed 4 years ago

j1warren commented 4 years ago

Screenshotzen

Now it always starts like here with fixed size. GTK 3.28.

PS Should have in mind that the number of rows will be different if started with or without the access to MSR (sudo). PPS Maybe add a Capabilities workaround note in README? $ sudo setcap cap_sys_rawio,cap_dac_read_search+ep ./zenmonitor seems suffice.

ocerman commented 4 years ago

Thanks for your report. It should be fixed in the latest version. I have also added capabilities workaround into readme.

j1warren commented 4 years ago

@ocerman, thank you for looking into it! In my case (see screen shot in #17) last 3 rows are still left out, so the scrollbar appears again. values from the end of resize_to_treeview() r.height = 327 uiHeight = 23 cellHeight = 21 rows = 35`

ocerman commented 4 years ago

@j1warren seems like cellHeight is not correct. Can you tell me which distro and GTK theme are you using?

j1warren commented 4 years ago

Ubuntu 18.04, gnome 3.28.2 https://github.com/lassekongo83/plano-theme

ocerman commented 4 years ago

@j1warren can you try it again? It should be fixed.

j1warren commented 4 years ago

@ocerman, I can confirm. Thank you!