ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

Added larger list from www.bannedwordlist.com/lists/swearWords.csv #111

Closed tliu22 closed 6 years ago

tliu22 commented 6 years ago

Added larger list from www.bannedwordlist.com/lists/swearWords.csv, especially in light of quick-validation and recommendation system.

sahilhasan commented 6 years ago

I would personally say we should remove lmao, lmfao and wtf. None of those are 'bad' enough to warrant not allowing imo

Edit: Forgot to say, thanks for committing this. I know a few ppl weren't too keen on having this on their commit history.

matthew-mcallister commented 6 years ago

Alright, this list is not bad. I think some duplicate words need removing (see my comment for an example). Also, the indentation should be fixed to look like

xyz = frozenset({
    'foo', 'bar', 'baz', ...
})

I agree with @sahilhasan's comments. In particular, wtf are valid initials and lmao could be based on a real name (i.e. last name Mao). Others might be problematic as well, e.g. "tit" could appear as part of several names.

tliu22 commented 6 years ago

Oh, I might've missed some duplicate words. Are there any more?

And I thought 'wtf' and 'lmao' were already removed?

sahilhasan commented 6 years ago

@tliu22 RIP I looked at the CSV (and I remembered from the previous list). Thats my fault. Sry

matthew-mcallister commented 6 years ago

@tliu22 "balls" and "ballsack"

kpengboy commented 6 years ago

Late to the game, but we should also expand the test cases to cover these new bad words.

kpengboy commented 6 years ago

And we need to get the Scunthorpe project done soon...