search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

Use multiple DNS servers for lookups #135

Closed jvperrin closed 5 years ago

jvperrin commented 6 years ago

This should make tests more reliable and mean that tests fail less often due to one single DNS server not responding quickly.

I'm not a fan of needing to loop through DNS servers if a negative result is given, but I don't see a better way currently.

dkess commented 6 years ago

If the issue is that DNS servers aren't responding quickly enough, how will this fix it? Looks like the DNS queries still have infinite timeouts.

jvperrin commented 6 years ago

The issue is more that our DNS server (pestilence) returns SERVFAIL I believe (or maybe NXDOMAIN, not exactly sure). Either way, it says the domain doesn't exist when it really does, so that's the point of having multiple other DNS servers to try.

jvperrin commented 5 years ago

I'm resolving this as ocflib tests haven't been failing due to this recently, and we should be mocking this or something in tests anyways. That being said, adding some retries or additional servers in here would still probably be a good idea to avoid any flaky behavior.