search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

fix mock test_cehcks_etc_passwd test #175

Closed MrMinos closed 5 years ago

MrMinos commented 5 years ago

Now fixed, but this part of the test caused the builds to fail in #173 #174.

Will close #174 and keep the #173 merge on master.

MrMinos commented 5 years ago

Merging to fix the master branch

abizer commented 5 years ago

please leave these PRs open to give us a chance to review them before merging

MrMinos commented 5 years ago

Yep learned the hard way. I should have followed that advice with the earlier PR that broke the builds, and check if jenkins fails. This is a hotfix for what was broken.

On Sat, May 4, 2019 at 5:42 PM Abizer Lokhandwala notifications@github.com wrote:

please leave these PRs open to give us a chance to review them before merging

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ocf/ocflib/pull/175#issuecomment-489376551, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYJTPQWPQHM4QCQKDZFD6TPTYUNPANCNFSM4HK2A6TA .

abizer commented 5 years ago

hotfix or not, if you're going to make a PR (and you should for all of these kinds of changes), keep it open, request review, and only merge it after someone else has had a chance to take a look at it.

MrMinos commented 5 years ago

I see. Lesson learned, thanks for entertaining my ignorance on codebase etiquette.

kkuehlz commented 5 years ago

There is a typo in the commit and odd formatting that could've been fixed before merging this in.