search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

Remove "cal" from restricted_usernames #184

Closed fydai closed 4 years ago

fydai commented 5 years ago

People's names can have "cal" in them. For example, reasonable names like "mattmcal" would be rejected for having cal as a substring.

nattofriends commented 5 years ago

Maybe keep it only for groups

2019年8月28日(水) 16:01 fydai notifications@github.com:

People's names can have "cal" in them. For example, reasonable names like "mattmcal" would be rejected for having cal as a substring.

You can view, comment on, or merge this pull request online at:

https://github.com/ocf/ocflib/pull/184 Commit Summary

  • Remove "cal" from restricted_usernames

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ocf/ocflib/pull/184?email_source=notifications&email_token=AAFTUFAGHHJEP3MLQM626DDQGYPDXA5CNFSM4IQ4YITKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HH2YCQA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFTUFDHXLSHODU7SSPZV4DQGYPDXANCNFSM4IQ4YITA .

dkess commented 5 years ago

These names are still allowed, they just go through manual approval. We almost never have to manually approve names so I'd rather play this safe and keep it in.

fydai commented 4 years ago

We never have to manually approve these names because there's a huge yellow warning saying "Username contains restricted words". It is very reasonable for names to contain the substring "cal". So I think it's reasonable to default-allow these names.

dkess commented 4 years ago

Perhaps an alum from before my time can give more context on why we have this policy in the first place?

kpengboy commented 4 years ago

The university doesn't like it when student groups use one of its trademarks (e.g. Cal, Berkeley, ...) IIRC we have traditionally extended this rule to apply to usernames. (Thus an acapella group, for example, can't create an account called calacapella or something like that.)

In general, I believe it's wise to respect the university's wishes regarding matters like these. *.berkeley.edu domain names for student groups are, after all, a privilege from the University, one they could take away (and in summer 2013, actually contemplated doing so).

On the other hand, we have persistently had a Scunthorpe Effect problem here. Perhaps we should look into fixing that?

fydai commented 4 years ago

All group accounts are manually created (by a staff running approve). As such, I think a suitable compromise would be to remove "cal" from restricted_usernames (allowing users to use a "cal" syllable) and put a (overridable) check into the approve script prompting for confirmation if the username begins with the substring "cal". What do you all think of this idea?

kpengboy commented 4 years ago

IIRC, at least at my time, we had an aversion to individuals picking usernames containing "cal". Perhaps @daradib could shed some light on whether I understood this rule correctly and if it is still useful? If not I would have no objection to restricting only for group accounts.

nattofriends commented 4 years ago

Did you read the 8 other comments on this PR?

cg505 commented 4 years ago

I think a suitable compromise would be to remove "cal" from restricted_usernames (allowing users to use a "cal" syllable) and put a (overridable) check into the approve script prompting for confirmation if the username begins with the substring "cal".

This makes sense to me. For non-group accounts, things will get caught by the real name checker (a la https://failure.ocf.berkeley.edu/rebuild/2019-11-26#319881).