search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

blackify #214

Closed ja5087 closed 4 years ago

ja5087 commented 4 years ago

was testing this out, thoughts? it has weird interactions with flake8 and that's why there are some ignores.

ethanhs commented 4 years ago

I personally don't like the black style, e.g. how it splits function definitions.

If we wanted to adopt an autoformatter, I would recommend autopep8, which uses the same underlying style checker flake8 does.

ja5087 commented 4 years ago

We already have autopep8. It's a pretty hands off autoformatter actually and time to time we do spend our time commenting on formatting. The chief advantage of black would probably be consistent and unambiguous formatting.

ethanhs commented 4 years ago

It's a pretty hands off autoformatter actually

I kind of like this about autopep8.

time to time we do spend our time commenting on formatting

Hm, do you have any instances of this in mind? I would imagine this would be useful to report upstream if there is something autopep8 isn't handling that it should.