ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

Add functions to modify LDAP attributes #29

Closed matthew-mcallister closed 8 years ago

matthew-mcallister commented 8 years ago

In particular, add a celery task.

At the moment, it fails its most useful function in that it won't work properly with the mail attribute which requires a privileged bind to read. This will probably have to be solved by scraping the output of ldapsearch.

It also may be confusing for create_ldap_entry_with_keytab to also modify LDAP entries now.

matthew-mcallister commented 8 years ago

Comments addressed.

chriskuehl commented 8 years ago

lgtm with a couple comments, no blockers

matthew-mcallister commented 8 years ago

Thanks for the extra comments. I took all the minor suggestions because I'm sure your python is more idiomatic than mine.