search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

finished moving constants to its respective files #56

Closed MrMinos closed 7 years ago

MrMinos commented 7 years ago

from … RT#5941

as noted in the ticket #5941, not sure about moving whole RESERVED_USERNAMES to ocflib/account/validators.py file, because that list is about 260 lines. Waiting on feedback about what to do. But all the other files in ocflib repository now should be using its own file's constants.

abizer commented 7 years ago

You can make the change, Chris mentioned it's only used in that one file.

Also you need to fix the build: there's a syntax error that's causing tests to fail.

MrMinos commented 7 years ago

comma being at ocflib/account/utils.py is correct. I just put a newline in the wrong place. ---Fixed it : ) -- sorry, take that back I'm looking into it. Thanks for letting me know

abizer commented 7 years ago

You don't need to do that, just log into Jenkins and re-trigger the job.

MrMinos commented 7 years ago

@tahabi I was looking for such functionality but I could not find it on my dashboard when I log into Jenkins

screen shot 2017-03-04 at 15 09 13

Please review the changes.

abizer commented 7 years ago

screenshot_20170304-151422

You have to log in with your OCF account credentials

MrMinos commented 7 years ago

Yea I did but I do not see it. I am guessing permission is not granted on my account.

Thanks for the feedback.

abizer commented 7 years ago

Make sure you're on the page for your PR. No extra permissions should be necessary.

On Mar 4, 2017 3:32 PM, "Minos Park" notifications@github.com wrote:

Yea I did but I do not see it. I am guessing permission is not granted on my account.

Thanks for the feedback.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ocf/ocflib/pull/56#issuecomment-284192901, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0_lvF8WxcKeRJc3Pu7QKlC_IxBDosTks5rifSmgaJpZM4MS6E2 .

MrMinos commented 7 years ago

Still don't see it.. I am at this address: https://jenkins.ocf.berkeley.edu/job/ocflib/job/PR-56/

screen shot 2017-03-04 at 15 35 42

And at this address: https://jenkins.ocf.berkeley.edu/job/ocflib/job/PR-56/4/

screen shot 2017-03-04 at 15 34 57
MrMinos commented 7 years ago

@tahabi please review my changes. Thank you!

jvperrin commented 7 years ago

@tahabi Only ocfroot users can trigger builds I believe, since having access to manage Jenkins allows for deploying software pretty much anywhere in the OCF, which could be misused.

chriskuehl commented 7 years ago

yeah currently we restrict all actions to ocfroot, but i only set that up because i was in a hurry

we could probably loosen that up a bit to allow build triggers and maybe some other relatively non-destructive things

parameterized build triggers could still be dangerous i guess, but probably fine

chriskuehl commented 7 years ago

otherwise lgtm, thanks for doing this!

abizer commented 7 years ago

should've checked my ocfroot privilege