search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

Updated Big Brother implementation #75

Closed abizer closed 7 years ago

abizer commented 7 years ago

Building off of @asaiacai's work, this tries to take into account some of the review suggestions from #74. Instead of loading hours from a hardcoded variable, hours are pulled from ocfweb but exposed in the usual REGULAR_HOURS format to minimize the amount of code that needs to be rewritten. Holidays work as usual because only the source of REGULAR_HOURS is being replaced, Day remains unchanged.

abizer commented 7 years ago

the tests will fail because HOURS_URL won't return something useful for this until the ocfweb PR is merged, among other things. You can test this by swapping HOURS_URL for 'http://nyx.ocf.berkeley.edu:8934/api/hours'