search

ocf / ocflib

Python libraries for account and server management
https://pypi.python.org/pypi/ocflib
Other
15 stars 32 forks source link

Replace pycrypto with pycryptodome #77

Closed jvperrin closed 7 years ago

jvperrin commented 7 years ago

pycryptodome appears to be a drop in replacement for pycrypto, so this should work fine, I'll see if tests pass or not. (rt#5885)

chriskuehl commented 7 years ago

here's the usual caveat: venv-update isn't smart enough to handle removing/adding packages that provide the same files, you may need to rm any pre-existing virtualenvs

maybe replace my celery fork at the same time so that people don't have to do this twice?

jvperrin commented 7 years ago

Yeah, good idea about updating the celery fork, I was actually just doing that, since this change also unblocks unpinning pyasn1 in ocfweb.

I think it might be ok, since just running make venv in this repo worked fine to remove the old package and install the new one without removing the whole venv, but maybe ocfweb would be different?

chriskuehl commented 7 years ago

if it works then that's cool. venv-update does not guarantee it will though, so potentially it could break /shrug

jvperrin commented 7 years ago

Alright, well I'll keep that in mind, if something breaks with venvs I'll know which PR to blame :P