search

ocf / ocfstatic

A static redesign of the main ocf website
https://new.ocf.berkeley.edu/
17 stars 34 forks source link

Menu bar is not aria compliant #315

Closed lawrencecchen closed 1 year ago

lawrencecchen commented 2 years ago

It should be possible (keyboard) tab to all dropdown items. Usually, this is handled by an external component/aria library (eg. react-aria, headlessui, radix-ui). Not sure what's the best for Vue, but headlessui looks reasonable. Thoughts?

https://user-images.githubusercontent.com/54008264/191653000-45d68301-5779-44c5-8a49-a14ea3daa32c.mov

skrider commented 2 years ago

Looks like Buefy's Menu Dropdowns are not aria compliant. Their regular dropdowns, interestingly, are. Seems like this would be a lot of work to fix for something that doesn't add a whole lot of value to the site.

Kalissaac commented 1 year ago

We use Chakra UI in our new React rewrite which provides accessible components, and I just tested and keyboard navigation seems to be working properly now. Please reopen if the issue persists.