search

ocf / ocfweb

The main ocf website
https://www.ocf.berkeley.edu
Other
38 stars 90 forks source link

Add endpoints for ocfstatic stats page #739

Closed bentref closed 2 years ago

bentref commented 2 years ago

Currently building out ocfstatic stats page. These endpoints are for the summary page and use mostly old ocfweb stuff.

The reasoning behind this is that we can re-use the Django API from the old website (at least for now) and just serve the new static site.

Kalissaac commented 2 years ago

Just wondering, is this still ongoing or ready for review?

bentref commented 2 years ago

Ready for review! There will be more endpoints added in the future but deploying this will make the ocfstatic stats summary page work

On Sun, Nov 21, 2021, 12:28 PM Kian @.***> wrote:

Just wondering, is this still ongoing or ready for review?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ocf/ocfweb/pull/739#issuecomment-974890518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIZJ7EFMFB3EGW6G3NM6WH3UNFI5PANCNFSM5IPO2BDA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Kalissaac commented 2 years ago

It seems like master is failing too..

bentref commented 2 years ago

Yeah, I'll look into that... we had this with ocfstatic a couple weeks ago and it was a deceptively simple fix of package version, hoping it's something similar

bentref commented 2 years ago

Also you might consider using a dictionary here instead of a list of tuples...

If we are going to sort by bandwidth as I currently do, a dictionary isn't ideal. I'm not sure this has to be sorted but using tuples would make it easier to sort