fix all the github permissions

ocf / projects

Overview of technical OCF projects

3 stars 0 forks source link

fix all the github permissions #43

Open nikhiljha opened 4 years ago

nikhiljha commented 4 years ago

Permissions are apparently supposed to be setup so that...

ocf/staff can push to anything except master
ocf/staff can merge to master, but only with 1+ approving reviews

However, this is inconsistently applied across GitHub. Maybe there's a global setting somewhere that can apply it? Or we can make a script?

kpengboy commented 4 years ago

Should the approval part still be different for different repositories? Like accepting approval from any staffer for ocfweb, but requiring a root staffer's approval for puppet?

cg505 commented 4 years ago

I don't think there is any global setting unfortunately. Additional notes:

PRs to ocf/etc don't necessarily need approval
Ideally we should require tests to pass, but unfortunately most repos don't run the PR workflow if it is a local (non-fork) branch, and obviously don't run the branch workflow for non-fork PRs. That means that there isn't a single check that we can require on all PRs. The solution could be to always run the PR check (this is what we do for puppet).

ethanhs commented 3 years ago

FWIW @kpengboy I don't think we can specify in the settings which group needs to approve its just "1 approver"

We could kind of hack around this by putting CODEOWNERS in all of the repos but that sounds both hacky and annoying to maintain.

I think we could write a script to do this automatically, github has a pretty good API...

nikhiljha commented 3 years ago

I think the CODEOWNERS solution is how most orgs do it. Just commit one file with a pointer to the GitHub groups, so no maintenance is required past the original setup I think?

ethanhs commented 3 years ago

Oh yeah if we can just point to groups we should just do that then.

fawaf commented 3 years ago

might also be worth to set up a template repo maybe? https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-template-repository