search

ocf / rt

Request Tracker service
https://rt.ocf.berkeley.edu
Other
11 stars 5 forks source link

Hide reply link on comments #4

Closed kpengboy closed 6 years ago

kpengboy commented 6 years ago

Fugly kludge because rt#7210 was the last straw for me

Ideally this would be a plugin or something, but I'm not knowledgeable enough to make one for the present

nattofriends commented 6 years ago

Just going to point out this doesn't help with email

On Fri, Mar 23, 2018 at 03:43 kpengboy notifications@github.com wrote:

Fugly kludge because rt#7210 was the last straw for me

Ideally this would be a plugin or something, but I'm not knowledgeable enough to make one for the present

You can view, comment on, or merge this pull request online at:

https://github.com/ocf/rt/pull/4 Commit Summary

  • Fugly hack to hide reply link on comments

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ocf/rt/pull/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs6FH_t9iKF7sTYE-3l9aFJKKimLJFKks5thNHIgaJpZM4S4gfc .

dkess commented 6 years ago

Not sure how most of these incidents happen, but email already has a decent deterrent built-in-- the reply-to header is different for replies than in comments, so as long as you don't change the To: address while you compose the email there isn't much risk.

On March 23, 2018 11:06:50 AM PDT, nattofriends notifications@github.com wrote:

Just going to point out this doesn't help with email

On Fri, Mar 23, 2018 at 03:43 kpengboy notifications@github.com wrote:

Fugly kludge because rt#7210 was the last straw for me

Ideally this would be a plugin or something, but I'm not knowledgeable enough to make one for the present

You can view, comment on, or merge this pull request online at:

https://github.com/ocf/rt/pull/4 Commit Summary

  • Fugly hack to hide reply link on comments

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ocf/rt/pull/4, or mute the thread

https://github.com/notifications/unsubscribe-auth/AAs6FH_t9iKF7sTYE-3l9aFJKKimLJFKks5thNHIgaJpZM4S4gfc .

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ocf/rt/pull/4#issuecomment-375753679

kpengboy commented 6 years ago

Yeah, this PR is geared towards making it harder to accidentally reply to a comment on the web interface. It won't stop people from making this error by changing the reply type from Comment to Reply on the comment page or by changing the To: address in their email client.

Another possibility is to write some sort of scrip that detects whether someone is trying to send a reply that quotes previous comments and reject that reply. It would have a larger net but be more difficult to develop and test (and I'd leave that task to someone else). What do you all think?

nattofriends commented 6 years ago

If it's mostly been the web interface so far this sounds like a decent stab at the problem.

On Sat, Apr 7, 2018 at 13:21 kpengboy notifications@github.com wrote:

Yeah, this PR is geared towards making it harder to accidentally reply to a comment on the web interface. It won't stop people from making this error by changing the reply type from Comment to Reply on the comment page or by changing the To: address in their email client.

Another possibility is to write some sort of scrip that detects whether someone is trying to send a reply that quotes previous comments and reject that reply. It would have a larger net but be more difficult to develop and test (and I'd leave that task to someone else). What do you all think?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/ocf/rt/pull/4#issuecomment-379496588, or mute the thread https://github.com/notifications/unsubscribe-auth/AAs6FNizwk_DjbQjFeMgGypBc30-QrWtks5tmR_AgaJpZM4S4gfc .

kpengboy commented 6 years ago

I'll (try to) do a more precise enumeration of why these mistakes happen when I get some free time. Of course, help is also always appreciated.

jvperrin commented 6 years ago

Bump, I think this is pretty useful and should be merged (I haven't tested it myself, but seems like a reasonable change to me)

kpengboy commented 6 years ago

Modified the patch to make it detect comments the proper way (instead of matching on the description text).