search

ocf / shared-pipeline

Shared OCF Jenkins Pipeline libraries
Other
0 stars 0 forks source link

Add createGist for creating GitHub gists #7

Closed jvperrin closed 4 years ago

jvperrin commented 4 years ago

I've tested this in https://github.com/ocf/puppet/pull/762, where it's used to make a gist if the contents are too big to fit in a pull request comment (max of 65536 characters). Currently, that puppet branch just has this repo pinned to this branch in the Jenkinsfile, but I'll unpin it after merging this.

This is also quite similar (and mostly taken from) the code in vars/checkGitHubAccess.groovy since that also talks to GitHub in a similar way.

I also had to log in to the ocfbot account and update the access token it's using to talk to GitHub to allow for interacting with gists, since that wasn't a permission originally included.

ja5087 commented 4 years ago

It might be useful to add an optional parameter for the gist description in case of additional metadata. Thoughts?

jvperrin commented 4 years ago

Sure, I think passing through the description would be reasonable, I'll add that as a parameter too although I'm not sure it'll actually get used, but it's easy enough to set