search

ocharles / prometheus-effect

Yet another Haskell Prometheus client
https://hackage.haskell.org/package/prometheus-effect
BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

Made project buildable and removed unused deps #4

Closed qrilka closed 6 years ago

qrilka commented 6 years ago

This PR intersects with #3 and #2 - I just wanted to show I went with to make the package a bit more usable in our project

ocharles commented 6 years ago

Thanks for all the issues! My guess is that I've forgotten a push, will check when I'm at my laptop tomorrow.

qrilka commented 6 years ago

@ocharles no updates yet?

ocharles commented 6 years ago

Ha, great timing! I'm just getting to this now. I've added the missing module, just fixing the other bits.

qrilka commented 6 years ago

@ocharles new version looks better but it still has misprint in weight/Weight.hs and unnecessary depencencies - do you want me to rebase this PR or you'll change this details yourself?

qrilka commented 6 years ago

Rebased our branch

ocharles commented 6 years ago

Is the removal of http-streams and io-streams correct? I can't remember if they are used by the WAI middleware or not.

qrilka commented 6 years ago

I don't see them used anywhere and stack build/test/bench work fine on our branch. Actually they are the reason I started our branch as they caused our project build failure because of some SSL dependency.

ocharles commented 6 years ago

Cool, away they go then!

ocharles commented 6 years ago

I'll cut a new release soon. Thanks for all the hep and feedback.

qrilka commented 6 years ago

@ocharles no news when new release will land on Hackage?

ocharles commented 6 years ago

Sorry for the delay, I'll release shortly.

On Wed, Nov 8, 2017 at 7:04 AM Kirill Zaborsky notifications@github.com wrote:

@ocharles https://github.com/ocharles no news when new release will land on Hackage?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ocharles/prometheus-effect/pull/4#issuecomment-342728846, or mute the thread https://github.com/notifications/unsubscribe-auth/AABRjgcn8yExp_5-Ju_BeK52C4_4K5c8ks5s0VJggaJpZM4QAV8K .

ocharles commented 6 years ago

Published, thanks for the nudge and sorry about a slightly slow process.