Incorrect output of histograms

ocharles / prometheus-effect

Yet another Haskell Prometheus client

https://hackage.haskell.org/package/prometheus-effect

BSD 3-Clause "New" or "Revised" License

11 stars 1 forks source link

Incorrect output of histograms #7

Open qrilka opened 6 years ago

qrilka commented 6 years ago

I'm aware of #6 but in the process we've stumbled upon the fact that histograms are streamed in prometheus-effect not the way they should be streamed. Prometheus docs says that time buckets should have _bucket suffix - https://prometheus.io/docs/concepts/metric_types/#histogram and prometheus-effect doesn't add it while prometheus-client does.

ocharles commented 6 years ago

I'm sorry this library caused you so many problems, but really appreciate you taking the time to report them. It looks like prometheus-client also suffered from the same bug but it got fixed in 0.3. As this library is going to be deprecated, I won't be fixing this, but I will leave this open as a reminder of what to add to the deprecation notice.