ochorocho / mattermost-plugin-nextcloud

Apache License 2.0
0 stars 1 forks source link

Current status of this plugin #2

Open dhx opened 4 years ago

dhx commented 4 years ago

Hi Ochorocho, stumbled over your plugin as I'm currently trying to implement an integration to nextcloud. Trying to compile the current code I had to fix a small regression in the usage of nextcloud.Client:

diff --git a/server/plugin.go b/server/plugin.go
index 29873f2..39dde80 100644
--- a/server/plugin.go
+++ b/server/plugin.go
@@ -41,7 +41,7 @@ type Rooms struct {
 func (p *Plugin) ServeHTTP(c *plugin.Context, w http.ResponseWriter, r *http.Request) {
        switch r.URL.Path {
        case "/status":
-               roomList := nextcloud.Client{"spreed", "room", "GET", ""}
+               roomList := nextcloud.Client{"apps/spreed/api/v1/room", "GET", ""}

                w.Header().Set("Content-Type", "application/json")
                if _, err := w.Write([]byte(roomList.Request())); err != nil {

And I've also seen that the nextcloud URL is currently hard coded (while there seems to be a configuration variable defined, which isn't used).

Before putting more effort into this I just wanted to ask if you're still using/maintaining this plugin or if you use another one in the meantime?

All the best! Daniel

ochorocho commented 4 years ago

Hey, currently i have no time to work on this plugin. That might change in a few month. But PRs are always welcome.

dhx commented 4 years ago

@ochorocho thanks for your fast response, I think it might help interested potential contributers to know about the current scope of this plugin, how far the integration goes / what works / what does not yet. I'll try to figure out and write down what I find (and create a PR for the README), but if you're willing to share a little what the achieved working status is it would be highly appreciated. Best regards, Daniel

ochorocho commented 4 years ago

@dhx the goal was:

grafik

In general i would focus on finish the Talk integration. A good Example is the zoom plugin

What is working: If you set your user credentials here and change the URL a request will create a new Room in the Talk app and post a link.

Thanks for working on this. :-)

Happy to help where i can. But just started to play with golang. So expect some mistakes i made during development.

ochorocho commented 4 years ago

@dhx if you could write down how to ease development. Somehow i would expect a "auto reinstall on file change" during development. But i could not find a solution so far.

dhx commented 4 years ago

@ochorocho thanks for your explanation, my focus at the moment goes more into the "post a file" direction - as for video calls we're currently using jitsi. The login flow being necessary anyway, I'll have a look at that.

Regarding the development setup having a rapid cycle is always nice, I often use inotifywait to trigger a build and install job on code updates (as I'm on Linux here). Following the info at: https://developers.mattermost.com/extend/plugins/developer-workflow/ "make watch" could rebuild the webapp portion on changes and it could also be possible to do a "make reset" to update a plugin - did you already try that?

ochorocho commented 4 years ago

Thanks will try this as soon as i get back to the plugin development