search

ochotonida / artifacts

MIT License
85 stars 58 forks source link

Hope you can use ConcurrentHashMap #342

Open CaoTrongThang opened 4 hours ago

CaoTrongThang commented 4 hours ago

Hey, I'm not good at coding but I've learned about Java a little bit, I think you should use the ConcurrentHashMap, instead of Hashmap in Java, switching to ConcurrentHashMap is easy. I keep getting concurrentmodificationexception crash in the modpack. I decompiled your code and see that you've been using Hashmap, I know that you're a good coder but switching to ConcurrentHashMap shouldn't do any harm to your code.

florensie commented 3 hours ago

Can you please provide a crash log. I don't see any obvious HashMaps that would need to be concurrent in the code.

CaoTrongThang commented 2 hours ago

thanks for reply me, here's the crash log, I don't know what mod did that.

crash-2024-11-16_01.56.38-client.txt