This PR addresses issues that were found while trying to install SRW at my computer.
Here are the issues that this Pull Request addresses:
../src/core/srsysuti.cpp:25:10: fatal error: 'sys/sysinfo.h' file not found
This is due to -DLINUX being hardcoded at this file: cpp/gcc/Makefile
fftw setup was wrong.
It was missing the download part for the FFTW tarballs
It was also inconsistent between the fftw2 and fftw3.
make clean is not really clean
It was leaving the libfftw.a at ext_lib
Results
After the fixes above I can simply do:
make all
Add /env/work/srw_python to my PYTHONPATH
Run examples
Other comments
I noticed the following that I would like to bring to your attention:
many products are being version controlled and they can lead to bad linking. E.g:
env/work/srw_python/srwlpy.so
ext_lib/GlutViewer.lib
ext_lib/GlutViewer64.lib
ext_lib/fftw3_64.lib
ext_lib/fftw3f_64.lib
ext_lib/fftw64_f.lib
ext_lib/fftw_f.lib
ext_lib/glut32.lib
ext_lib/glut64.lib
ext_lib/libf2c.a
ext_lib/libf2c.lib
ext_lib/libfftw3_mac.a
ext_lib/libfftw3f_mac.a
ext_lib/libfftw_f_i686.a
ext_lib/libfftw_f_x86_64.a
ext_lib/libfftw_mac.a
ext_lib/libfftwf_mac.a
ext_lib/libpng.lib
ext_lib/libpng64.lib
ext_lib/zlib.lib
ext_lib/zlib64.lib
product SRW Library should never be on version control as it is specific to my compiler and system: env/work/srw_python/srwlpy.so and can lead to issues if not cleaned up properly.
Attn. @mrakitin I think that now your Conda recipe will build again for MacOS and Windows.
Summary
This PR addresses issues that were found while trying to install SRW at my computer. Here are the issues that this Pull Request addresses:
Results
After the fixes above I can simply do:
PYTHONPATH
Other comments
I noticed the following that I would like to bring to your attention:
many products are being version controlled and they can lead to bad linking. E.g: env/work/srw_python/srwlpy.so ext_lib/GlutViewer.lib ext_lib/GlutViewer64.lib ext_lib/fftw3_64.lib ext_lib/fftw3f_64.lib ext_lib/fftw64_f.lib ext_lib/fftw_f.lib ext_lib/glut32.lib ext_lib/glut64.lib ext_lib/libf2c.a ext_lib/libf2c.lib ext_lib/libfftw3_mac.a ext_lib/libfftw3f_mac.a ext_lib/libfftw_f_i686.a ext_lib/libfftw_f_x86_64.a ext_lib/libfftw_mac.a ext_lib/libfftwf_mac.a ext_lib/libpng.lib ext_lib/libpng64.lib ext_lib/zlib.lib ext_lib/zlib64.lib
product SRW Library should never be on version control as it is specific to my compiler and system: env/work/srw_python/srwlpy.so and can lead to issues if not cleaned up properly.
Attn. @mrakitin I think that now your Conda recipe will build again for MacOS and Windows.