search

ocilo / skype-http

Unofficial Skype API for Node.js via HTTP
https://ocilo.github.io/skype-http
MIT License
51 stars 24 forks source link

Add image sending #46

Closed Sorunome closed 6 years ago

Sorunome commented 6 years ago

This adds the ability to send images via

sendImage({
    file: '/path/to/image.jpg',
    name: 'name_to_display_on_skype.jpg'
}, threadId);
Sorunome commented 6 years ago

I am not very familiar with typescript, could someone please help me resolving the last few lint errors? (Specifically the typedefs)

demurgos commented 6 years ago

Thanks for your PR. I'll take a look at it (and the other issues 😛)

demurgos commented 6 years ago

Thanks you for your contribution. I fixed the few issues in #47, please use a feature-branch next time (instead of master) so its easier to patch the branch of your PR.

Overall it seems fine, I checked that it did not break the library but I did not have the code to actually test if it works so I trust you for this. I'd like to spend some time this week on this library so I'll try to come up with better tests. Note that even if I'm merging now, the XML string sent to Skype should be properly sanitized (instead of concatenating the values). I'll open an issue for this.

Sorunome commented 6 years ago

Thank you for merging it and I'll keep the branch stuff in mind for next time.

EDIT: uuuuuh, here is only the master branch and the gh-pages branch? o.O