Closed demurgos closed 6 years ago
Merging #70 into master will increase coverage by
4.69%
. The diff coverage is65.11%
.
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 40% 44.69% +4.69%
==========================================
Files 45 64 +19
Lines 1220 1376 +156
Branches 119 128 +9
==========================================
+ Hits 488 615 +127
- Misses 704 732 +28
- Partials 28 29 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/lib/api/send-image.ts | 18.51% <ø> (ø) |
:arrow_up: |
src/lib/api/get-conversations.ts | 41.66% <ø> (ø) |
:arrow_up: |
src/lib/api/get-conversation.ts | 22.22% <ø> (ø) |
:arrow_up: |
src/lib/providers/microsoft-account.ts | 30.32% <0%> (ø) |
:arrow_up: |
src/lib/contacts/api/get-user.ts | 100% <100%> (ø) |
|
src/lib/types/contact-group.ts | 100% <100%> (ø) |
|
src/lib/types/display-name.ts | 100% <100%> (ø) |
|
src/lib/types/iso-date.ts | 100% <100%> (ø) |
|
src/lib/types/contact.ts | 100% <100%> (ø) |
|
src/lib/contacts/api/get-invites.ts | 100% <100%> (ø) |
|
... and 41 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e15cda...ab72f6e. Read the comment docs.
This commit uses the new contacts API to get all the contacts. Retrieving a single contact is no longer possible. Accepting and rejecting contact requests will need to be updated as well (it still uses the old API).
New types were written for this update. The new types are in the
types
directory must be imported using deep imports (import {Contact} from "skype-http/types/contact";
). The old types are still inlib/interfaces
for the moment.This is a breaking change.
@James91 You should be able to install it with
skype-http@next
once it is merged. Could you check if it fixes your issue?