codecov[bot]
commented
6 years ago Codecov Report
Merging #71 into master will increase coverage by
0.15%. The diff coverage is43.1%.
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 44.69% 44.85% +0.15%
==========================================
Files 64 67 +3
Lines 1376 1418 +42
Branches 128 130 +2
==========================================
+ Hits 615 636 +21
- Misses 732 753 +21
Partials 29 29| Impacted Files | Coverage Δ | |
|---|---|---|
| src/lib/api.ts | 28.26% <ø> (ø) |
:arrow_up: |
| src/lib/types/location.ts | 100% <ø> (ø) |
:arrow_up: |
| src/lib/types/agent.ts | 100% <ø> (ø) |
:arrow_up: |
| src/lib/types/agent-info.ts | 100% <ø> (ø) |
:arrow_up: |
| src/lib/types/contact.ts | 100% <100%> (ø) |
:arrow_up: |
| src/lib/mri.ts | 41.42% <100%> (+0.84%) |
:arrow_up: |
| src/lib/types/api-profile.ts | 100% <100%> (ø) |
|
| src/lib/types/contact-profile.ts | 100% <100%> (ø) |
|
| src/lib/login.ts | 21.05% <20%> (-0.16%) |
:arrow_down: |
| src/lib/contacts/contacts.ts | 30% <20%> (+7.77%) |
:arrow_up: |
| ... and 6 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ab72f6e...582bb08. Read the comment docs.
This commit adds a step during the login operation to fetch the username from the Skype DB instead of just passing the login. This means that it is now possible to use email or usernames with mixed case to login.
It also adds try/catch blocks around the read operation when deserializing the results, registers the
GroupConversationMRI type, renamestypes/profiletotypes/contact-profileand fixes some errors with the interfaces.