search

ocilo / skype-http

Unofficial Skype API for Node.js via HTTP
https://ocilo.github.io/skype-http
MIT License
51 stars 24 forks source link

New features #86

Closed grigori-gru closed 6 years ago

grigori-gru commented 6 years ago

Hello! I use this methods in my matrix-skype project and it would be great if you add it to your project. I have never used typescript before, probably there are some incorrect interafaces or types.

demurgos commented 6 years ago

Thanks for the PR. I am in the process of updating the conversation API (#87) to type-check the responses and simplify it a bit. It means that your PR will have to be rebased: I'll take care of it this week-end.

Having all the features already working is a huge help. 👍

demurgos commented 6 years ago

I am going to rebase and merge this PR first. The other PR changes too much things around conversations and I need more time to ensure that everything works fine and there are no problems migrating. It will be safer to merge this PR first and publish it.

demurgos commented 6 years ago

I just finished reviewing your changes: it's pretty good. I just did a small update in createConversation to avoid using an empty thread id and check for the location header.