Open mitchcapper opened 6 years ago
I think maybe mention that the live:
prefix doesn't actually mean much? Even without it, myaccountname
won't work because the account username is actually myaccountname@gmail.com
- this was the source of my confusion.
Ah the live: prefix would not be for logging in but returned on the account type itself. You do need to use the full MSA login (ie user@mailbox.com) if not using older skype only usernames.
@mitchcapper Right, I was suggesting that maybe that's worth including in this PR because it's not entirely obvious for the uninitiated 😀 (as long as that section is being updated anyway)
@vladdypwnz I am actually having a hard time finding where you saw the live: prefixing. I read the readme, checked the ts file docs for login, and even the old generated docs. Where were you seeing it?
@mitchcapper I naively assumed it would show up properly in Skype itself. I think the live prefix is new to the most recent version of Skype. Here's what the profile for the test account looks like: (keep in mind that vladcansignup
in this case, even without live:, is still not a valid username)
OK I updated the PR to add a sample under quickstart for an MSA login, beyond that while MS shows MSA's with the live: prefix as when you login to skype it still requires user@domain.com for the login flow I think it should be fine.
@vladdypwnz pointed out the documentation is confusing about MSA accounts not working. I tested one and it seemed fine, are the docs are out of date or am I missing something else?